Comment 13 for bug 1170794

patch here: user/rogan/lp1170794_skip_renewal_deposit_charge

This is similar to Jason's patch but maybe some things changed between then and now. Testing on master as of today showed this behavior with an item that had a deposit:

Staff Client Checkout: showed ITEM_DEPOSIT_REQUIRED message, charged amount
Staff Client Renewal: showed ITEM_DEPOSIT_REQUIRED and charged amount
OPAC Login: attempted to renew and got "Failed to renew 1 item(s)"

after patch testing gave:

Staff Client Checkout: showed ITEM_DEPOSIT_REQUIRED message, charged amount
Staff Client Renewal: did not show ITEM_DEPOSIT_REQUIRED and did not charge deposit again
OPAC Login: attempted to renew and it successfully renewed

Note, that I did find that if you are renewing from an aborted transit that message supersedes the deposit one. That may be an existing bug somewhere but I suspect is broader in scope than this testing. The behavior of the ITEM_DEPOSIT_PAID message remained consistent before and after. I'm not a fond of it's terminology but that's not in the scope of this either of course.