Comment 2 for bug 1681864

Revision history for this message
Ben Shum (bshum) wrote :

Working branch started up: user/bshum/lp161864-i18n-db-seed-fixing

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp161864-i18n-db-seed-fixing

All this does is add a pocommentclean step in the middle of updatepo make target that will selectively wipe out comments for a given db.seed locale file. Tested only on Ubuntu 16.04 presently with translate toolkit 1.13.0. There may be differences on other platforms in how this ends up behaving.

The test procedure would involve running "make newpot" in build/i18n first, to deploy the new template changes for IDs to the base db.seed.pot file. Then run "make LOCALE=ar-JO updatepo" or "make update_all_locales" to hit all of them at once, to apply the changes throughout between the templates and locale PO files.

As a potential hiccup, it looks like updatepo hasn't been called between POT and PO in a very long time (since it's not a step in the wiki instructions for release making predating 2.6). So it has been shown for me that running updatepo to apply this fix also nets a ton of other PO updates and changes. Testing this fix will require some finesse with managing the various i18n pieces that need updating and repair.

Not putting a pullrequest on this yet, while we investigate further and discuss any other potential ramifications.