Comment 35 for bug 1715697

Okay, I humbly offer my proposed patch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/holdings-view-omnibus-signoff-rebase-patch

working/user/dbwells/holdings-view-omnibus-signoff-rebase-patch

While the change looks large, a good bit of it is reverting previous changes to contain the bug noted here. This also fixes the regression only; other potential display and workflow tweaks can come later. My reasoning behind this patch:

- Existing code distinguishs 'adds' from 'edits' via two wrappers, spawnHoldingsAdd and spawnHoldingsEdit. With this commit, empty volume adding now extends the 'add' function rather than the 'edit' one, as this seems more intuitive.

- The previous change had extended both the catalog app and another similar directive which is only used in a merging context. Since the merge context had no ability to add anything, and the new code was not wired up to any interface, this has simply been removed (for now).

- The volcopy app is set up around the concept of passing in 'prototype' vol/copy objects of varying degrees of completeness. It then loops over these to generate the interface. The previous code
extended this setup with a loop over a potential 'owners' array to generate empty volumes, but this unrelated loop within a loop seemed counterintuitive (and was the source of the original bug). This change has been removed, and empty volume creation now hews more closely to the original model.