Web Client: Missing 'already checked in' alert on checkin screen
Bug #1729438 reported by
Terran McCanna
This bug affects 6 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Confirmed
|
Undecided
|
Unassigned |
Bug Description
The xul client had an on-screen alert indicating that an item had already been checked in that is missing in the web client. (See screenshot from xul client.)
Changed in evergreen: | |
status: | New → Confirmed |
tags: | added: regression |
tags: | removed: webstaffclient |
tags: |
added: circulation removed: webstaffprodcirc |
To post a comment you must log in.
I took a look at this. I don't have the knowledge to fix it, but I thought I'd pass along what I learned to save folks some digging:
1) Lines 214-216 of Open-ILS/ web/js/ ui/default/ staff/circ/ checkin/ app.js are looking for final_resp. evt.textcode and final_resp. evt.copy_ barcode. However, final_resp.evt is an array, so the textcode and copy_barcode are actually in final_resp.evt[0].
2) It doesn't like holding the textcode and copy_barcode in $scope.alert. However, when I rename $scope.alert to something ridiculous (e.g. $scope.ilovemycats) in the checkin app.js and the relevant ng-if statement in the Open-ILS/ src/templates/ staff/circ/ checkin/ t_checkin. tt2, the "Already checked in" alert does show up.
I hope this helps somebody with a better sense of EG's code conventions and best practices to find a fix to this issue!