Comment 7 for bug 1773417

Dan,

I am using the Add ... Volumes from the Action menu in the holdings view.

When I first open a record where my test library has no holdings, I get the following in the Javascript console:

Holdings fetch with: rid=3837995 org=119 copy=false vol=false empty=true
angular.js:14199 TypeError: Cannot read property 'join' of undefined
    at holdings.js:205
    at Object.q [as forEach] (angular.js:325)
    at holdings.js:203
    at angular.js:16696
    at m.$eval (angular.js:17994)
    at m.$digest (angular.js:17808)
    at angular.js:18033
    at f (angular.js:6045)
    at angular.js:6324
(anonymous) @ angular.js:14199
(anonymous) @ angular.js:10707
(anonymous) @ angular.js:16704
$eval @ angular.js:17994
$digest @ angular.js:17808
(anonymous) @ angular.js:18033
f @ angular.js:6045
(anonymous) @ angular.js:6324
setTimeout (async)
k.defer @ angular.js:6322
$evalAsync @ angular.js:18031
(anonymous) @ angular.js:16603
e @ angular.js:16712
$$resolve @ angular.js:16745
resolve @ angular.js:16728
(anonymous) @ angular.js:16681
oncomplete @ pcrud.js:213
OpenSRF.Stack.handle_message @ opensrf.js:689
OpenSRF.Stack.push @ opensrf.js:669
OpenSRF.websocketConnection.onmessage @ opensrf.js:364
socket.onmessage @ opensrf_ws.js:78
holdings.js:40 Canceling fetch for org 119
holdings.js:67 Holdings fetch with: rid=3837995 org=119 copy=true vol=true empty=true

The above repeats 2X.

I then click on Holdings View. The first time that I did so tonight, Show Empty Volumes, Show Empty Libraries, and Show Copy Details were checked. Show Empty Volumes was not checked. My library did not show up until I checked Show Volume Details.

After noticing that, I checked and unchecked the various boxes in different orders. It seemed to be unpredictable when my library with no holdings would show up. I believe it showed up once with just Show Empty Volumes and Show Empty libraries checked. However, at another time, I had to also check Show Volume Details (which automatically checked Show Copy Details) before it would show up. The Show Holdings at or below selection is at my branch, so nothing else would show up.

Note that while I was checking and unchecking the boxes, the console messages would repeat as the page reloaded.

I then checked the grid table entry for my branch, and chose Add ... Volumes from the Actions menu. This opened the Vol/Copy Editor in a new tab with only the volume information visible. Save & Exit was disabled and mousing over it gave me a cursor that indicated it would not work (i.e. a circle with a line through it on Chrome).

Maybe I do not know what I am doing, but nothing that I did to the volume entry would enable the Save & Exit. I even chose a prefix and suffix at one point to have all fields filled in.

It may be a problem local to this VM as I did load a bunch of branches this week. However, most of what I have loaded has made it into rel_3_0 for the 3.0.8 relase. Also, I am testing with rel_3_0, which may be significant. It could be that my code is junked up or that the changes are not working with 3.0 for some reason.

I should be able to look at this more later with a fresh build, and I can even go so far as to wipe out the installed code on the VM or just build a new VM. I will not be likely to look at this again for a few days to a week given that I am doing an upgrade this Sunday night.

If someone else wants to test it more in the mean time, I won't object. If it works for someone else, then great.