Comment 3 for bug 1791162

Revision history for this message
Galen Charlton (gmc) wrote :

Initial results of testing: I think this needs a little more time to bake and should not hold up the beta (though it makes sense to keep this in mind for the release candidate).

One minor problem (or request): it would be nice if a top-level 'make check' invoked the webstaff and eg2 unit tests.

Of more import: the npm build steps run /every/ time you do a make, including for a make install, which of course is usually done as sudo root. That means that node_modules and the like get their ownership changed to root, making subsequent makes as the dev user fail due to file permission issues. This is awkward, to say the least.

Also, Open-ILS/web/eg2 should be included in a clean.