Comment 5 for bug 1835953

Revision history for this message
Jason Stephenson (jstephenson) wrote : Re: Autorenewals should not be attempted on circs where auto_renewal_remaining is NULL

An alternative to #1 in my previous comment occurred to me. We could also check for auto_renewal_remaining of NULL in the reactor and set the reason to something like autorenewal not allowed. We could even make a new event for this.

Doing this will notify the patron that the item can't be autorenewed. This might be preferable to just setting the event state to invalid and then not notifying the patron.

What's the consensus?