Comment 3 for bug 1895699

I've done some testing of this patch, and a lot of it is looking good!

It's great that the on_reserve filter can be appended to a search url, which provides a great tool for constructing urls to easily retrieve titles on reserve for one org unit, multiple org units, or all.

When circ.course_materials_opt_in is set to TRUE for the consortium the on_reserve filter works great.

If only some org units are opted in to the course module, however, I've found some of the results confusing.

I know the bug description states that the filter would apply after a search, but just a comment that it would be useful to have the "Limit to course materials" checkbox immediately available when I choose my search library.

I also don't see a way via that catalog to limit to titles that are NOT on reserve. Though the ability to craft a url that does that is useful.

One issue I see is that titles not on reserve at my search library can appear in the filtered list.

As an example, say BR1 and BR3 are the only org units that have circ.course_materials_opt_in set to TRUE.

Both BR1 and BR3 own copies of "Ready Player One", but only BR1 has added their copies to their course. When searching for "Ready Player One" in BR3, and applying the on_reserve limit via the checkbox in the catalog, "Ready Player One" appears in the filtered list for BR3 even though it is not on reserve at BR3. My expectation was that the results would include only titles that have BR3 copies on reserve.

Thanks for your work on this, Jane!