Comment 3 for bug 1715396

Revision history for this message
Dan Wells (dbw2) wrote :

John, thank you for digging into this. I have a few questions:

1) Is your LDAP-enabled library using LDAP logins for OPAC, staff, or both?

2) Would you be able to post your auth_proxy app_settings contents (with passwords, etc. redacted)?

I think I understand why your change works for you, but it does seem contrary to the intention of the code, i.e. treating lack of an org argument as an 'undefined' case where org filters are not applied. In other words, I believe this change would break some cases the other way, but I am not quite sure yet.

I think a safer fix is ultimately going to be making the LDAP request a little more graceful in failure, and finding cases were we could but are not yet passing in an org argument would be a good idea as well, if such places exist.

Dan