The delete_stack() RPC call in the client can be sent using either call()
or cast(), with cast() the default. This is never what you want, because
the call could raise an exception and you want to hear about that.
We're now passing cast=False explicitly everywhere. We always were in
heat-cfn-api and heat-api, but failing to do so in StackResource caused bug
1499669, which was corrected by I039eb8f6c6a262653c1e9edc8173e5680d81e31b.
Changing the default to call() will prevent anyone making that same mistake
again.
Reviewed: https:/ /review. openstack. org/374444 /git.openstack. org/cgit/ openstack/ heat/commit/ ?id=73a886d8062 54b30067441a321 bf816b0f624828
Committed: https:/
Submitter: Jenkins
Branch: master
commit 73a886d806254b3 0067441a321bf81 6b0f624828
Author: Zane Bitter <email address hidden>
Date: Wed Sep 21 19:13:02 2016 -0400
RPC Client: don't cast() delete_stack by default
The delete_stack() RPC call in the client can be sent using either call()
or cast(), with cast() the default. This is never what you want, because
the call could raise an exception and you want to hear about that.
We're now passing cast=False explicitly everywhere. We always were in 653c1e9edc8173e 5680d81e31b.
heat-cfn-api and heat-api, but failing to do so in StackResource caused bug
1499669, which was corrected by I039eb8f6c6a262
Changing the default to call() will prevent anyone making that same mistake
again.
Change-Id: Idd6a27988dadbf 1cd8376de24b19f 2226f6ae5b7
Related-Bug: #1499669