Comment 2 for bug 1567047

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/302417
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ea92e735829ae4271fcbae932f69ffdbda268546
Submitter: Jenkins
Branch: master

commit ea92e735829ae4271fcbae932f69ffdbda268546
Author: Tyr Johanson <email address hidden>
Date: Wed Apr 6 13:36:05 2016 -0600

    Allow local/enabled panels to order relative to enabled panels

    A dashboard enabled file in local/enabled is not able to appear before,
    or inbetween any core panels.

    The list of panels appears to be intended to be sorted by file name,
    but all files in /enabled and always presented in the nav ahead of
    any files from local/enabled, no matter the file name.

    This appears to be a bug in util/settings.py that does an rsplit to
    separate file name from path, but accidentally uses the full list of
    split items, instead of just the file name.

    For example, a file with __name__ of
    'openstack_dashboard.enabled._1040_project_volumes_panel' splits into
    ['openstack_dashboard.enabled', '_1040_project_volumes_panel']. When
    this list is fed to cmp(), it will always come before a panel in
    local/enabled such as
    ['openstack_dashboard.local.enabled', '_0001_my_new_panel']

    Change-Id: Ic169ccf0db1e04ec42fe999df6648117ce9efe84
    Closes-Bug: 1567047