Comment 5 for bug 679715

Revision history for this message
Yuv (yuv) wrote :

Hi Thomas,

feedback was "considered" to the extent that I could consider / make sense of it with my limited skillset.

point 1: I don't find any path -- relative or absolute -- in src/celeste/Main.cpp around line 470. Nor do I see where in my code I refer to paths? please advise.

point 2: The way I understood your feedback was to implement this in a single location of the code rather than in every single file that has to be translated, as with my first attempt. This is now implemented once in /src/hugin_base/hugin_utils/utils.h while before it was implemented in src/hugin_base/huginapp/ImageCache.cpp and not available from other parts of the code. I don't understand the feedback regarding xwLocale - this is outside of wX. Please explain what you mean.

I was not aware of gettext dropping support for MSVC and am sorry for MSVC users that gettext is causing problems for them. Is there a better alternative to gettext that is easier on the multi-platform requirements of Hugin?

Last but not least, I branched this out in its own branch because it is a superior way to get people (inlcuding myself) who care about localization to contribute / try to improve. It keeps it on the radar screen. I started this patch as an itch, more than a year ago, to help a translator who asked about translating those untranslated strings; and I realize that I have not been very good at keeping track of what I wanted to do. This is because personally I like my software to be in English and so localization is not on my radar screen where it should be. The hg branch is cheap, but if it disturbs you feel free to purge it.