Comment 13 for bug 679917

Revision history for this message
tmodes (tmodes) wrote :

The patch needs some more polishing (I had no time to compile, but some comments from have a look on it):
* The timer is not correctly freed at the end.
* Don't use local variables beginning with m_ (these should only used for member variables to get a better overview)
* Status reports should go to stdout and not to stderr (and no blabla, what should this?? bad style). Also fprintf can make problems with Windows. There are better alternatives: e.g. using cout, DEBUG_TRACE,
* The 2 conversion of the filename should not be necessary.
* It needs to be checked if the path in the project file is correct (the cwd can be an other directory than the dir with the image files, e.g. user navigated to lens or mask files.)
* Don't autosave if the project does not contain any image.
* Maybe the EVT_TIMER macro would be better suit to the existing code than using the eventhandler.