Comment 24 for bug 1022719

Revision history for this message
John Paul Adrian Glaubitz (glaubitz) wrote :

Plus, the suggested patch by Patrick is very ugly as it has to test every single character and it is very difficult to read and understand.

If you drop the patches by Patrick (https://bugs.launchpad.net/inkscape/+bug/1022719/+attachment/3219645/+files/inkscape-0.49-urifix.patch) and (the one by https://bugs.launchpad.net/inkscape/+bug/695120/+attachment/2180360/+files/inkscape-0.48.1-abs4chdir.patch), then apply the one by Michael Karcher, you will dramatically improve the readability of the the code and solve both Bug #695120 and #1022719. Plus, you are actually using C++ code instead of C which is kinda more fitting in a C++ source.

Cheers,

Adrian