Comment 0 for bug 1269206

Revision history for this message
David Mathog (mathog) wrote :

The attached patch implements a first pass of modifications to the text and font dialog that let it control text decorations.
Shift-control-t opens that dialog, select the "decorate" tab.

This patch also includes the changes in the patch in bug 1243401, which restored text decoration rendering.

This patch is applied in the typical manner, but it modifies share/icons/icons.svg, and those changes will not be evident until
that file is copied to wherever you keep your system's version of that file. On my linux box it was: /usr/local/share/inkscape/icons/icons.svg.

SVG 1.1 only supports CSS 2 text decorations (line type). Future SVG will probably support CSS3 (line style and color too).
There is a switch in the tab to select CSS 2 or CSS 3 compatibility. SInce this is a primitive first pass, the color and style lines do not gray out when CSS 2 is selected. Additionally the color support is rudimentary at this point for CSS 3, it only lets you choose whether the color comes from the text's fill or if it is "custom", but custom at this point is just a fixed color. To be useful that needs to open up into a color picker. Additionally the decorations buttons do not yet pick up their state from the selected text.

A test file and a screen shot of it will be posted next.

There is one outright bug in this somewhere. Every once and a while the "text-decoration" field is placed outside the style, like this:

style="...."
text-decoration="underline"

whereas it should be

style="...; text-decoration:underline;"

If one of those outside the style fields is present the "?" inherit button will generally not work properly.