© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
Testing patch V05 with current trunk on OS X 10.7.5:
1) AFAIU the proposed patch (V05) implements a solution similar to the one in the original bug description. It does not include a solution which would allow to associate a display unit for font size to a drawing task (document) as proposed in comment 2 (after a discussion with the bug reporter on irc).
2) The proposed patch exposes the global setting from the text tool preferences in the text tool controls bar and in the 'Text and Font' dialog as unit selector menu. Changing the display unit for font size on the text tool controls bar or in the 'Text and Font' dialog does change the global preference setting (the last used setting will be saved across sessions and used again the next time Inkscape is launched) - it does not act as a temporary override of the user's text tool preferences in the current session (as originally proposed by the reporter).
3) The exposure of the global setting in the preferences is redundant with the proposed patch (V05) applied - with this solution, it should be removed from the text tool preference pane IMHO, because the unit selector in both the text tool context (controls bar) and in the 'Text and Font' dialog will expose and update the same global setting.
4) The proposed patch V05 has a usability problem (irrespective of the drawing scale of the current document): the recalculated numeric value expressing the current font size in newly chosen units is incorrect, and only updated to the correct value when focus is moved out of the unit selector and the text object is reselected. The 'Apply' button in the 'Text and Font' dialog cannot be used either to force an update to the correct value. This makes the new feature difficult to use (as there is no indication for the user when which value displayed in the GUI is the "correct" one).
5) When changing the display units in the 'Text and Font' dialog, the 'Apply' should not be made sensitive: changing the display unit for font size does (in theory) not change the style of the text object itself (there is nothing to apply to the text object - it is a change which affects in which units the font size is represented in the GUI).
6) Opening the 'Text and Font' dialog produces 30 Gtk-CRITICAL warnings on the console (not present without the patch applied).
Over all, reviewing (and accepting) of the proposed solution is up to Gez - I can't tell whether it would have prevented the costly mistake which recently put again more focus on this report.
Personally, I'd probably still favor either
a) the originally proposed solution (keep global setting as is, allow temporary override in the current session (or for the current document view) per unit selector in the tool context; use global setting for new sessions/other documents opened in the current session), or
b) the more complex solution combining the original proposed solution with a newly introduced document property for the display units of the font size (defaults to the unit set in the preferences unless specified otherwise).