Affect icons not affected by UI icons size

Probably due to the gtkrc file shipping with Inkscape on Windows which sets the icons size for 'inkscape-decoration' explicitly:

gtk-icon-sizes = "gtk-menu=16,16:gtk-small-toolbar=16,16:gtk-large-toolbar=24,24:gtk-dnd=32,32:inkscape-decoration=16,16"<https://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/head:/build.xml#L720>

The icons themselves are designed for 12x12 px (AFAIU this smaller size was originally intended as size for all icons of the type 'inkscape-decoration' - e.g. also the toggle buttons to lock/unlock and hide/unhide layers).

Some icons I could find which are too small compared to all others around.
Also the palette is thinner, but this is not a problem: we'll have more colors visible and free space on canvas :)

I've copied the first line in file 'etc\gtk-2.0\gtkrc' over the first line in file 'share\themes\MS-Windows\gtk-2.0\gtkrc' and now everything is fine.
Is there a reason for which these two lines should be different?

Bug and fix confirmed on Windows XP, Inkscape trunk revision 10938.

Sorry, I don't understand the last post: does it mean that the fix was already present in rev.10938?

Yes, I confirm the bug is still present in 10938, and that the gtkrc fix (or workaround) works.

On my PC there are two trunk distributions, one from a month ago, and one from last week. The older one has large icons and the new one small ones. However there are no changes between the distributions in these files as assayed like this:

$ pwd
/c/progs/inkscape2
$ diff ./inkscape/share/themes/MS-Windows/gtk-2.0/gtkrc ../inkscape/inkscape/share/themes/MS-Windows/gtk-2.0/gtkrc
$ diff ./inkscape/etc/gtk-2.0/gtkrc ../inkscape/inkscape/etc/gtk-2.0/gtkrc

So changing one of these may "fix" the problem, but it seems to me like the root issue is elsewhere. Unless one of these files had a problem which was revealed by the gtk update referred to in post 1?

> the root issue is elsewhere

Newer versions of GTK+ (2.22.1 -> 2.24.8) and GLib (2.26.1 -> 2.28.8).
Specially the 2.24 branch of GTK+ has seen many changes/fixes for the win32 backend (but glib seems to have shuffled env and util functions for win32 as well).

Hi.

Have done a test with Inkscape version r11593 on both Windows XP and 7.
It turns out that the icons looks correct in Windows XP, and ridiculous small in W7.

The version I've tested with is the one that is downloaded from
"https://skydrive.live.com/?cid=09706d11303fa52a&resid=9706D11303FA52A!217&id=9706D11303FA52A!217"

I try to upload two screen shots for comparison.

Due to the recent commit/uncommit of devlibs, I've had to revert-update the project (recommitting the old version would have been a cleaner way to do so, IMHO).
Pity I forgot the change in gtkrc I had done: now I've the small icons back again.
But the worse is that the file 'etc\gtk-2.0\gtkrc' is not there anymore! It seems it has never been there (looking in the log).
I don't know where it had come from, but its line was good to me.
Is there anybody that still have it and can post the relevant line here, please? Or at lease point out the changes to the first line in file 'share\themes\MS-Windows\gtk-2.0\gtkrc' (I remember the two lines were much different but I suppose that only few numbers should be changed)?
Thanks in advance.
Luca

The etc\gtk-2.0\gtkrc file is not a copy from the devlibs, but is created directly from build.xml (see lines 734+).
It's first two lines are:
----
gtk-icon-sizes = "gtk-menu=16,16:gtk-small-toolbar=16,16:gtk-large-toolbar=24,24:gtk-dnd=32,32:inkscape-decoration=16,16"
gtk-toolbar-icon-size = small-toolbar
----

As for the uncommit, I've already admitted publicly that it wasn't a good idea. Again, sorry for the annoyance.

Good, thank you a lot! The lines are exactly what I needed.
Why not placing them in the 'share\themes\MS-Windows\gtk-2.0\gtkrc' file?
Never mind for the uncommit: I should have saved the modifications (or at least think about them) before reverting.

@LucaDC - I'm going to modify the gtkrc file so that it uses the correct icon size. But I find the icons (particularly the layer's eye and lock) a bit too big with "inkscape-decoration=16,16", compared to the other UI elements. I've tried with 13,13, and it looks better IMHO.
Could you please test an give your opinion?

Note that it doesn't fix the issue, and the affect icons are still not affected by the icon size parameter.

Also reproduced on Ubuntu 11.10, Inkscape trunk revision 11888 and 0.48.1. Removing win32 tag.

<opinion>
The 'Affect' icons are designed for icon size 12x12 (see also the 1:1 size in 'icons.svg') - AFAIU they belong to a special type of status icons (inkscape-decoration) which are smaller than the regular toolbar icons. They are not expected to be affected by gtk-settings for regular toolbar icons. The same size is e.g. used for the eye/lock icons in the layer list of the layers dialog.

Not reproduced on Ubuntu 12.10 Unity (default guest account) - the 'Affect' icons are rendered as expected with their default (as designed AFAIU) 12x12 size on the toolbar.

Under Gnome 3.6, the default Adwaita theme apparently overrides the built-in fallback size (12x12), and the icons (including those for the layer status) are rendered larger (and thus look slightly blurry).

On OS X, I can freely override any theme settings (because there is no gconf/gsettings daemon which overrides user gtk settings globally), and I prefer to set the Affect icons (via 'inkscape-decoration' gtk setting) to their native size (12x12).
</opinion>

<opinion>
Personally I find that 12x12 icons just "look small" compared to all other UI graphics, having them been designed for that size or not (maybe the design was not so good and it could just be improved if that is really the desired size).
In any case, I'm not a fan of small UI graphics because it makes harder to see what you are clicking on and for new users to understand what each button is for.
I could agree that 16x16 give the impression of being a bit bigger than others. I'll give a try to 13x13 as soon as I can, but my impression is that it's too near to 12x12 and I would have tried 15x15 instead.
About changing the size, please check which icons (and other UI elements) are affected (e.g. see the attachment of post #2) because maybe some of them should be moved outside the "affect" group and be kept 16x16. For example I don't see any reason for which the palette size should depend on other icons' size.
</opinion>

LucaDC> my impression is that it's too near to 12x12

Mine is that the icons fallback on Windows is not 12x12, but something like 10x10 (it seems that it's bigger on Ubuntu than on Windows). That would explain why the "Affect" icons look really small when inkscape-decoration is not set. The other icons outside the group also look too big in 16x16.

I understand that some icons use a different setting (it is legitimate for the layers dialog icons), but I don't see why here. IMHO, there should be no difference between the "Affect" group and the other secondary bar icons.

@JazzyNico:
You're right: I've tried 13x13 and they look less small than I expected. It's not a bad setting but I see there are some details that get rendered not nicely.
We could try 13x13 and see what others think about. I still feel that 'affect' icons look a bit smaller than others but it's just a minor aesthetic issue that, IMHO, does not impact usability too much.

LucaDC> We could try 13x13 and see what others think about.

I've only tested 13x13, 16x16 and nothing. Did you test with higher values? 14x14 might be a good choice too. If you feel 13x13 is too small, I have nothing against committing 14x14 directly.

I'd vote for 14x14 because IMHO icons render better (e.g. see the "arm" of the closed lock).
For the same reason I'd change the "gtk-menu" size to 14x14 also (now it's 13x13).

Workaround committed in the devlibs, revision 38 (gtk-menu and inkscape-decoration set to 14).

This seems to have been fixed in 0.48.5.

However, this problem is now happening in Inkscape 0.91pre3 r13670 x64. The 'win32' version of Inkscape 0.91pre3 r13670 is fine.

On 2014-12-16 09:05 (+0100), rickmastfan67 wrote:
> However, this problem is now happening in Inkscape 0.91pre3 r13670 x64.
> The 'win32' version of Inkscape 0.91pre3 r13670 is fine.

Tracked in bug #1372150: icons in 0.91pre2, 64-bit, on Win7, 64-bit some blurred, others too tiny.

I also have inconsistent icon sizes, where some icons are affected by the icon size settings and others are not, with 0.92.0 on x86_64 Linux (compiled myself). My libgtk version is 2.24.23. This actually is a usability issue since on the high-DPI display of my laptop, I need the "larger" size option to work comfortably. I have attached screenshots taken on a normal-DPI display - hence the "larger" option looks overblown here, but it also makes it most obvious which icons change size and which don't.

I also had problem with to small icons on layers list and in scaling buttons.
After changing first line in C:\Program Files\Inkscape\share\themes\MS-Windows\gtk-2.0\gtkrc to:

gtk-icon-sizes = "gtk-menu=24,24:gtk-small-toolbar=24,24:gtk-large-toolbar=24,24:gtk-dnd=32,32:inkscape-decoration=24,24"

I got consistent size of icons in every toolbar and button.

I use Inkscape 0.92.2 (5c3e80d, 2017-08-06) on Windows 10 64B on FullHD laptop with 14" screen.