Launchpad itself

  1. Bug #900431
  2. Comment #5

Comment 5 for bug 900431

Revision history for this message
William Grant (wgrant) wrote : Re: ~<team>/+activereviews forbidden to team member, allowed to public

+activereviews was failing to show a merge proposal for lp:~michael.nelson/software-center-agent/scaclient-add-distroseries-filter into lp:~canonical-isd-hackers/software-center-agent/scaclient. ~canonical-isd-hackers is subscribed to the proposed branch, owns the target branch, and has a requested review on the merge proposal.

The problem is that noodles' branch is stacked on lp:software-center-agent, which used to be lp:~canonical-isd-hackers/software-center-agent/trunk, but was recently moved to lp:~canonical-ca-hackers/software-center-agent/trunk -- its owner was changed. Access transitivity over stacking results in ~canonical-isd-hackers not being able to see the source branch, nor the MP.

To fix the immediate +activereviews issue, subscribe ~canoncial-isd-hackers to lp:software-center-agent. If ISD shouldn't have access any more, the project's branch visibility policies will need tweaking to point at ~canonical-ca-hackers instead.

The bug here is that the visibility checks in LP's branch queries don't include the transitive stacking check. WITH RECURSIVE ftw?