Comment 0 for bug 690668

Revision history for this message
Chow Loong Jin (hyperair) wrote :

  affects libindicate
  affects dbusmenu
  affects indicator-messages

As per the title, these projects leak memory. dbus_g_proxy_end_call requires you
to free the memory it allocates, including the GErrors. The patch attached does
that.

indicator-messages has an additional leak, which I'm not sure is libdbusmenu's
or indicator-messages' fault. libdbusmenu passes a GdkPixbuf into
indicator-messages, indicator-messages scales it and doesn't free the original
pixbuf. However, libdbusmenu doesn't free those pixbufs either, so it gets
stored. The same thing happened with indicator-sound, but the patch for that has
already been committed.

These patches are by no means complete. I'm just hunting down memleaks one by
one using Valgrind's massif, and targeting functions that allocate too much memory.

--
Kind regards,
Loong Jin