Comment 3 for bug 1881916

Revision history for this message
Matthew Swart (mswart343) wrote :

In response to "... however it proved difficult to add to the UI". Thinking of two possible solutions.

1. Commissioning scripts that require parameters are not automatically run and do not show up in the list of available scripts in the UI. Don't see this as a viable option as it requires a large number of checks and filtering, and seems a bit of a hacky solution.

2. For reference, when I mention a drop-down I mean something similar to the page with the options for the commissioning script that drops down. You could either have a drop-down for each commissioning script that requires parameters or a single drop-down with some sort of paging. Should be dynamically sized by the number of parameters (possibly put a max on the number of parameters). The drop-down would have the script name at the top, a dynamic table of all parameters, and a 'continue' button that moves forward with the commissioning after checking each parameter (if required) is filled. Also, because the parameters are statically typed it should be simple to add in dynamic type checking as well as sanitize input. This is probably the more preferred solution, however it would be a decent amount of work adding in a dynamic drop-down with a variable number of scripts and parameters.

Just some thoughts, let me know what you think.