Comment 7 for bug 1802438

Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :

Rodolfo,

the configuration in the job works this way:
neutron-lbaas --(lbaas driver api)--> midonet driver --(rest api)--> midonet

"midonetclient.api_lib" logs are about the "(rest api)" part above.
midonet driver basically just pass-through the object given via the driver api.
the change in question changed the object passed in the "(lbaas driver api)". i.e. it broke the driver api.

those tempest tests are from lbaas repo.
the job in question runs those tempest tests against a deployment with midonet backend.
tempest tests are expected to be backend agnostic in general.

the patch in question is ok for the reference implementation. it's why it won't break lbaas CI.
it happened to break the other driver (midonet) though.

i don't understand why you think passing the whole object is incorrect.
yes, i know the length of the request. it's inefficient and i don't like it.
(i vaguely remember that i even filed a bug complaining those objects are too verbose and redundant
while ago.)
but it works as far as it has the fields used by the backend.
midonet driver can trim them down as an optimization but it's a separate topic.