Comment 19 for bug 1960412

Reviewed: https://review.opendev.org/c/openstack/nova/+/841760
Committed: https://opendev.org/openstack/nova/commit/3d698040a17f39954fe095502dafb2b193120243
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 3d698040a17f39954fe095502dafb2b193120243
Author: Alexey Stupnikov <email address hidden>
Date: Sat Feb 19 21:38:44 2022 +0100

    Add functional tests to reproduce bug #1960412

    Instance would be affected by problems described in bug #1949808
    and bug #1960412 when queued live migration is aborted.

    This change adds functional test to reproduce problems with
    placement allocations (record for aborted live migration is not
    removed when queued live migration is aborted) and with Neutron port
    bindings (INACTIVE port binding records for destination host are not
    removed when queued live migration is aborted).

    It looks like there are no other modifications introduced by Nova
    control plane which should be reverted when queued live migration is
    aborted.

    This patch also changes neutron fixture:

    - neutron fixture was changed to improve active port binding's
      tracking during live migration: without this change port's
      binding:host_id is not updated when activate_port_binding() is
      called. As a result, list_ports() function returns empty list
      when constants.BINDING_HOST_ID is used in search_opts, which is
      the case for setup_networks_on_host() called with teardown=True.

    Conflicts:
    - nova/tests/fixtures/libvirt.py
    - nova/tests/fixtures/neutron.py

    NOTE. There is no need to change libvirt fixture because original
    problem with lack of address element is no longer there (I also
    removed related note from commit message itself). NeutronFixture
    class is defined in different place instable/wallaby, but code
    staus the same.

    Related-bug: #1960412
    Related-bug: #1949808
    Change-Id: I152581deb6e659c551f78eed66e4b0b958b20c53
    (cherry picked from commit 1ad287bf9a8f65ce68c14f4634775f58abda15c2)
    (cherry picked from commit 479b8db3ab07dd1f50c029904cca17f3a5708685)