Comment 13 for bug 1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38302
Committed: http://github.com/Juniper/contrail-controller/commit/382cccd87dd1565ec09b889cb8934592a3d60f9e
Submitter: Zuul (<email address hidden>)
Branch: master

commit 382cccd87dd1565ec09b889cb8934592a3d60f9e
Author: Michał Cłapiński <email address hidden>
Date: Wed Dec 13 17:58:20 2017 +0100

General changes for Windows

Mixed changes related to net,vnsw/agent/{cfg,controller,diag,filter,pkt}:
1. boost::array<uint8_t, X> to IpYAddress::bytes_type where applicable.
IpYAddress::bytes_type is std::array if c++11 and boost::array otherwise
and on Windows we compile with c++11.
2. addr.to_bytes().c_array() to addr.to_bytes().data()
Difference between boost::array and std::array
3. variable length arrays to dynamic allocation with smart pointers
4. s_addr to s_address, DELETE to DEL, EVENT_MAX to EVENT_MAXIMUM
s_addr, DELETE, EVENT_MAX are reserved on Windows
5. bind to ::bind
To avoid confusion with std::bind
6. and more various bugs

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: I7b963703d6d0aefb6591bc40ab6048351bb30593
Partial-Bug: #1737177