contrail-controller changes for Windows

Bug #1737177 reported by Pawel Marchewka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R5.0
Won't Fix
High
Pawel Marchewka
Trunk
In Progress
Undecided
Pawel Marchewka
OpenContrail
Fix Committed
Undecided
Pawel Marchewka

Bug Description

Merge contrail-controller changes for Windows from github.com/codilime/contrail-controller to Juniper/contrail-controller project on review.opencontrail.org

Initial changes:
  https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
  https://github.com/codilime/contrail-controller/commits/windows3.1/src

Changed in opencontrail:
assignee: nobody → Pawel Marchewka (pawelmarchewka)
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38302
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38333
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38342
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38333
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38382
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38342
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38384
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38302
Committed: http://github.com/Juniper/contrail-controller/commit/382cccd87dd1565ec09b889cb8934592a3d60f9e
Submitter: Zuul (<email address hidden>)
Branch: master

commit 382cccd87dd1565ec09b889cb8934592a3d60f9e
Author: Michał Cłapiński <email address hidden>
Date: Wed Dec 13 17:58:20 2017 +0100

General changes for Windows

Mixed changes related to net,vnsw/agent/{cfg,controller,diag,filter,pkt}:
1. boost::array<uint8_t, X> to IpYAddress::bytes_type where applicable.
IpYAddress::bytes_type is std::array if c++11 and boost::array otherwise
and on Windows we compile with c++11.
2. addr.to_bytes().c_array() to addr.to_bytes().data()
Difference between boost::array and std::array
3. variable length arrays to dynamic allocation with smart pointers
4. s_addr to s_address, DELETE to DEL, EVENT_MAX to EVENT_MAXIMUM
s_addr, DELETE, EVENT_MAX are reserved on Windows
5. bind to ::bind
To avoid confusion with std::bind
6. and more various bugs

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: I7b963703d6d0aefb6591bc40ab6048351bb30593
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38382
Committed: http://github.com/Juniper/contrail-common/commit/442663f4e8d7c15a5f1c884f4332385d066f2c53
Submitter: Zuul (<email address hidden>)
Branch: master

commit 442663f4e8d7c15a5f1c884f4332385d066f2c53
Author: Pawel Marchewka <email address hidden>
Date: Fri Dec 15 12:36:45 2017 +0100

Changes for windows

Changes for windows:
1. Do not build usock_server on windows
2. Use uint8_t instead of u_int8_t
3. Added cast in setsocktopt
4. Changed size_t to std::size_t in some methods (to match to
declaration)

Change-Id: I1336413e541e25ee95c29074f29aa6952e0f5d97
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38461
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38463
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38464
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38463
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38466
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38342
Committed: http://github.com/Juniper/contrail-controller/commit/05212ee13413504f0384c6d8169cff1749994079
Submitter: Zuul (<email address hidden>)
Branch: master

commit 05212ee13413504f0384c6d8169cff1749994079
Author: Mateusz Jablonski <email address hidden>
Date: Thu Dec 14 17:04:12 2017 +0100

General changes for Windows

Mixed changes related to schema, xmpp, vnsw/agent/{kstate, vgw, test-xml}:
1. boost::array<uint8_t, X> to IpYAddress::bytes_type where applicable.
IpYAddress::bytes_type is std::array if c++11 and boost::array
otherwise and on Windows we compile with c++11.
2. add linking with advapi32 and gdi32 on Windows
(needed by OpenSSL)
3. do not link with librt on Windows
4. use multiplatform boost::filesystem instead of open/stat/read
5. add missing 'return' to some functions
6. add missing include
7. and more various bugs

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: Ifa9a6182300a16c4210d3dc866a333048317b944
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38464
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38487
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38384
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38487
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38463
Committed: http://github.com/Juniper/contrail-controller/commit/e83c61b714058b476494dd91a67f2e6745ecc6e7
Submitter: Zuul (<email address hidden>)
Branch: master

commit e83c61b714058b476494dd91a67f2e6745ecc6e7
Author: Michał Cłapiński <email address hidden>
Date: Tue Dec 19 15:53:04 2017 +0100

src/vnsw/agent changes for Windows

1. Created empty class VnswInterfaceListenerWindows
2. Disabled some libs and flags in SConscript for Windows

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/vnsw/agent
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/vnsw/agent

Change-Id: Ifa57e5a2b3f0e8129dbd647e7e6e378ca8996a86
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38461
Committed: http://github.com/Juniper/contrail-controller/commit/1a587b0ae3877175b30aa94d69b1d2f0dcb521b7
Submitter: Zuul (<email address hidden>)
Branch: master

commit 1a587b0ae3877175b30aa94d69b1d2f0dcb521b7
Author: Pawel Marchewka <email address hidden>
Date: Tue Dec 19 14:36:11 2017 +0100

Agent services changes for Windows

Agent services changes for Windows:
1. Variable length arrays is only supported in gcc and it is not a part
of C++ standard. We decided to use dynamic allocation and scoped_array.
2. Empty (zero element) array at the end of structure is not portable.
3. Use boost::asio::ip::address_v*::bytes_type, boost from C++0x
uses std::array instead of boost::array

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/vnsw/agent/services
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/vnsw/agent/services

Change-Id: I938ae8b6b9e1744046c763ecdc40473cc3b56369
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38384
Committed: http://github.com/Juniper/contrail-controller/commit/50c2fdbe648edd244886e8cd88d057f3f82a08dc
Submitter: Zuul (<email address hidden>)
Branch: master

commit 50c2fdbe648edd244886e8cd88d057f3f82a08dc
Author: Pawel Marchewka <email address hidden>
Date: Fri Dec 15 14:48:33 2017 +0100

Don't build nexthop_client and nexthop_server on Windows.

NexthopDBServer uses UnixDomainSocketServer which is not supported on
Windows.

Change-Id: Ibf117424629b66c220c5513da440b73706a0b251
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38485
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38516
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38485
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38518
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38519
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38521
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38521
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38487
Submitter: Katarzyna Rybacka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38518
Committed: http://github.com/Juniper/contrail-controller/commit/8b3cc8b405882956630074b294167a7f7b4f551a
Submitter: Zuul (<email address hidden>)
Branch: master

commit 8b3cc8b405882956630074b294167a7f7b4f551a
Author: Mateusz Jablonski <email address hidden>
Date: Thu Dec 21 13:13:58 2017 +0100

Fix for signed-unsigned comparison

Fix for signed-unsigned comparison in test_xml.cc

Change-Id: I191267d18c8e44bc65f62457fb4bfa4fb0d51276
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38516
Committed: http://github.com/Juniper/contrail-common/commit/37dbe7724b0c4d9f0a728a1d63b5468b49f1a2ae
Submitter: Zuul (<email address hidden>)
Branch: master

commit 37dbe7724b0c4d9f0a728a1d63b5468b49f1a2ae
Author: Pawel Marchewka <email address hidden>
Date: Thu Dec 21 12:08:16 2017 +0100

Boost thread linking issue

Fix for boost thread linking issue in tests.

Change-Id: Icef7f3fcee5ea20c55b35654e15228f91e03b253
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38464
Committed: http://github.com/Juniper/contrail-controller/commit/c846bf5fc491977afa735e85cb24ae744dda55cd
Submitter: Zuul (<email address hidden>)
Branch: master

commit c846bf5fc491977afa735e85cb24ae744dda55cd
Author: Katarzyna Rybacka <email address hidden>
Date: Tue Dec 19 16:25:51 2017 +0100

Agent dns changes for Windows

Agent dns changes for Windows:
1. Changed 'libxml2' to 'xml2', so it could be included on Windows either.
2. Move boost_chrono not to be included on Windows because std::chrono is used
3. Changed lib prefixes and suffixes to be exact for every platform
4. Removed cmn_sources due to dependency cycle in scons
5. Ifndefed two of bind_tests because Named Config is not used on Windows

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/dns
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/dns

Change-Id: I623012d492a83fa4b5abc4ee68fabd02519f434f
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38465
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38521
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38333
Committed: http://github.com/Juniper/contrail-controller/commit/c3242d424531e35017361daa3f14a1f10b130bd6
Submitter: Zuul (<email address hidden>)
Branch: master

commit c3242d424531e35017361daa3f14a1f10b130bd6
Author: Pawel Marchewka <email address hidden>
Date: Thu Dec 14 11:23:59 2017 +0100

Partial SNAT support for Windows

Partial SNAT support for Windows:
1. Added vrouter_hyperv.py and vrouter_hyperv_inject_ip.ps1.
Those files setup SNAT VM and setup HYPERV
2. Moved 'validate_uuid' function to separate file common.py
to not install whole vrouter_netns.py on Windows

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/vnsw/opencontrail-vrouter-netns/opencontrail_vrouter_netns/
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/vnsw/opencontrail-vrouter-netns/opencontrail_vrouter_netns/

Change-Id: I85d9cb7b3932b5d2e8b81fa0cc53565f79db49f0
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38466
Committed: http://github.com/Juniper/contrail-controller/commit/c1586d32c6290882ffa0b7982fda0f64bf99c6c7
Submitter: Zuul (<email address hidden>)
Branch: master

commit c1586d32c6290882ffa0b7982fda0f64bf99c6c7
Author: Michał Cłapiński <email address hidden>
Date: Tue Dec 19 19:11:01 2017 +0100

src/vnsw/agent/contrail changes for Windows

1. Used env['LIBPREFIX'] and env['LIBSUFFIX'] instead of 'lib' and '.a'
2. Added code in SCons and .xml for MSI generation using WiX
3. Used forward_adapter while registering boost::factory
4. Added config for Windows Service Wrapper
5. Disabled vhost creation on Windows

Change-Id: I2f1189b45aa8f054cac058035b96626238a73bac
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38590
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38591
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38521
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38590
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38487
Committed: http://github.com/Juniper/contrail-controller/commit/49147ab5d9a9d0a3f285373ba5bb4e8880ab87d7
Submitter: Zuul (<email address hidden>)
Branch: master

commit 49147ab5d9a9d0a3f285373ba5bb4e8880ab87d7
Author: Katarzyna Rybacka <email address hidden>
Date: Wed Dec 20 15:43:32 2017 +0100

Agent ifmap changes for Windows

Agent ifmap changes for Windows:
1. Changed DELETE to DEL because DELETE is reserved on Windows.
2. Changed deprecated posix function index() to recommended strchr().

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/ifmap
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/ifmap

Change-Id: I578d942b6d879e18c14b45339e4ac1c80f46b586
Depends-On: Icef7f3fcee5ea20c55b35654e15228f91e03b253
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38519
Committed: http://github.com/Juniper/contrail-common/commit/fa9ef31576ff55f3f841980bb3609ac6687c432c
Submitter: Zuul (<email address hidden>)
Branch: master

commit fa9ef31576ff55f3f841980bb3609ac6687c432c
Author: Pawel Marchewka <email address hidden>
Date: Thu Dec 21 13:18:49 2017 +0100

Changes for Windows

1. Redefinition of strtok_r to strtok_s on Windows
2. Use memset instead of deprecated bzero.

Change-Id: I7fbc331f475853747c09f3661a09dcb7237080c4
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38465
Committed: http://github.com/Juniper/contrail-controller/commit/b2854e582728bbe19217b2270db7baff6fd111e1
Submitter: Zuul (<email address hidden>)
Branch: master

commit b2854e582728bbe19217b2270db7baff6fd111e1
Author: Mateusz Jablonski <email address hidden>
Date: Tue Dec 19 17:14:06 2017 +0100

General changes for Windows

Mixed changes related to bgp, db, http, vnsw/agent/cmn, vnsw/agent/uve:
1. change all occurrences of u_intX_t to portable uintX_t
2. add missing include net/if.h header
(for if_nameindex() and if_freenameindex() functions)
3. add missing include unistd.h header
(for sysconf() function)
4. define and use NOEXCEPT (for C++ version-independent noexcept)
5. add const specifier where needed
6. change && in macro to nested macros for MSVC compatibility
7. change closesocket to close_socket
(closesocket() is a Windows built-in function)
8. add empty implementation of uve/vm_stat* classes
(vm_stat is currently not implemented on Windows)

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: Iee4b80e105ab2c6d691a6faf385bcf541087b27a
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38521
Committed: http://github.com/Juniper/contrail-controller/commit/122017d811f053502c9c3fc817b83b1e2b1a27f6
Submitter: Zuul (<email address hidden>)
Branch: master

commit 122017d811f053502c9c3fc817b83b1e2b1a27f6
Author: Pawel Marchewka <email address hidden>
Date: Thu Dec 21 13:26:11 2017 +0100

Changes for windows related to oper directory

1. Added base/os.h which should include redefinition of strtok_r to
strtok_s on Windows
2. Renamed DELETE to DEL
3. Added NULL implementation of instance_task
4. Added os specific implementation of GetOsSpecificParams.
5. Added posix_fcntl.h with fcntl stub method - from windows stubs
6. Added optional os_guid_ to Interface - used on windows
7. Use memset instead of bzero
8. Use full scope name of boost::asio::placeholders, since it may
confilct with std::placeholders

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/vnsw/agent/oper

Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/vnsw/agent/oper

Change-Id: I0d045dd4a6ec7e0146b1442f8378a53dba59b5e4
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38485
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38613
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38591
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38625
Submitter: Michal Clapinski (<email address hidden>)

tags: added: vrouter windows
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38625
Committed: http://github.com/Juniper/contrail-build/commit/b825ef4fddb8bd0d9a7b9efb3c09c655e3c77c1b
Submitter: Zuul (<email address hidden>)
Branch: master

commit b825ef4fddb8bd0d9a7b9efb3c09c655e3c77c1b
Author: Michał Cłapiński <email address hidden>
Date: Tue Jan 2 15:59:52 2018 +0100

Multithreaded build fix for Windows

1. Fixed flakiness in multithreaded build for Windows
2. Added NOGDI flag to compilation

Change-Id: Ib88461e4af5fef4bd2d721680c4a4c79fcef21ff
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38590
Committed: http://github.com/Juniper/contrail-controller/commit/95b45fe7739d320ba78490c5fdadf78665756cb6
Submitter: Zuul (<email address hidden>)
Branch: master

commit 95b45fe7739d320ba78490c5fdadf78665756cb6
Author: Pawel Marchewka <email address hidden>
Date: Fri Dec 29 14:26:40 2017 +0100

Added boost_thread to libs (changes for Windows)

Added boost_thread to libs. Boost::thread should be used instead of
pthread, since it is portable. Pthread was not removed from libs since it is still
being used by some not ported (to Windows) controler compoments.

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/

Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/

Change-Id: Ie75ad05b48ff2930beef1408365d902cbc75ca3c
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38485
Committed: http://github.com/Juniper/contrail-controller/commit/80e4ab60418ba1491b1f7865466fe74919d4b90f
Submitter: Zuul (<email address hidden>)
Branch: master

commit 80e4ab60418ba1491b1f7865466fe74919d4b90f
Author: Mateusz Jablonski <email address hidden>
Date: Wed Dec 20 12:38:27 2017 +0100

src/vnsw/agent/test changes for Windows

1. Create empty implementation of test_util_tap.cc on Windows
2. Used forward_adapter while registering boost::factory
3. Use portable __attribute__packed__open__ and __attribute__packed__close__
(defined in I5a902da559cf63e08f0912cacedcbf8687552f8c)
4. Change all occurrences of sizeof(pkt.payload) to 0
(sizeof of flexible array is not supported on MSVC)
5. Change pthread to boost::thread
6. Add missing 'return' to some functions
7. Use bind() from global namespace explicitly

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: Ie15b27ccd9850b1fce6c57c50dd8b1e2a13bd2f1
Depends-On: I5a902da559cf63e08f0912cacedcbf8687552f8c
Depends-On: I191267d18c8e44bc65f62457fb4bfa4fb0d51276
Depends-On: Ie75ad05b48ff2930beef1408365d902cbc75ca3c
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38682
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38613
Committed: http://github.com/Juniper/contrail-analytics/commit/9e11a6f922466dd5020d85f0517804731af672ad
Submitter: Zuul (<email address hidden>)
Branch: master

commit 9e11a6f922466dd5020d85f0517804731af672ad
Author: Pawel Marchewka <email address hidden>
Date: Tue Jan 2 12:47:09 2018 +0100

Added boost_thread to libs (changes for Windows)

Added boost_thread to libs. Boost::thread should be used instead of pthread,
since it is portable. Pthread was not removed from libs since it is still
being used by some not ported (to Windows) controller compoments.

Change-Id: Id4908c8d6fc19eb2d535b3dd8826142a6accc656
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38591
Committed: http://github.com/Juniper/contrail-common/commit/efabdc9a74965e1a727c33ccc201fd0828a86be2
Submitter: Zuul (<email address hidden>)
Branch: master

commit efabdc9a74965e1a727c33ccc201fd0828a86be2
Author: Pawel Marchewka <email address hidden>
Date: Fri Dec 29 14:38:07 2017 +0100

Use boost::thread in tests (changes for Windows)

Use boost::thread in tests instead of pthread, since it is portable.
Added boost_thread to libs. Pthread was not removed since it is still
required by some not ported components.

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src/

Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src/

Change-Id: I68f8637fc9ff2faf994a1c84c7016f3147d7d8ed
Depends-On: Ie75ad05b48ff2930beef1408365d902cbc75ca3c
Depends-On: Id4908c8d6fc19eb2d535b3dd8826142a6accc656
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38682
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38701
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38702
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38703
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38702
Committed: http://github.com/Juniper/contrail-vrouter/commit/b72a8e3661dee620d4a48b0de77245af03926f0c
Submitter: Zuul (<email address hidden>)
Branch: master

commit b72a8e3661dee620d4a48b0de77245af03926f0c
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jan 5 17:03:31 2018 +0100

Fix type casting in Windows code

Initial work:
https://github.com/codilime/contrail-vrouter/commits/windows

Change-Id: I27d919ac9210e762ef24867733c1298837a3c08b
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38730
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38731
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38703
Committed: http://github.com/Juniper/contrail-controller/commit/2b65cff07ada8afad0830db721ed27c80423ecf9
Submitter: Zuul (<email address hidden>)
Branch: master

commit 2b65cff07ada8afad0830db721ed27c80423ecf9
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jan 5 17:14:22 2018 +0100

Partial fixes for Agent compilation on Windows

1. Change `define` in CCFLAGS to portable version
2. Add new include directory on Windows
3. Remove Windows version of Rapidjson SConscript
(After update updating Rapidjson to v1.1.0)

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/controller/src
Further work and cleanup:
https://github.com/codilime/contrail-controller/commits/windows3.1/src

Change-Id: I74847a044c7ecb7c74f9f3b8506471d0f736e2d2
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38682
Committed: http://github.com/Juniper/contrail-vrouter/commit/2e303a1b4531cfb69c52f86cd5586cbd81fd0804
Submitter: Zuul (<email address hidden>)
Branch: master

commit 2e303a1b4531cfb69c52f86cd5586cbd81fd0804
Author: Michał Cłapiński <email address hidden>
Date: Thu Jan 4 19:43:49 2018 +0100

Minor fixes for Windows

1. Casted void* to char* before addition
2. Removed one unnecessary define (Windows only)
3. Updated Visual Studio project files
4. Add missing include

Change-Id: I01e72b87320840c7bf379171b1762bf45ed55270
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38769
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38771
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38730
Committed: http://github.com/Juniper/contrail-controller/commit/e4f287083279311d7d6c1c4d4d75a49e605c78fc
Submitter: Zuul (<email address hidden>)
Branch: master

commit e4f287083279311d7d6c1c4d4d75a49e605c78fc
Author: Mateusz Jablonski <email address hidden>
Date: Mon Jan 8 17:03:23 2018 +0100

Partial fixes for Agent compilation on Windows

1. Add new files to windowsstubs
2. Add type casting because of different `{get,set}sockopt` signatures
3. Remove unnecessary files

Change-Id: I64a7d957ad0014faa8c3a937e36ce05a263342c6
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38701
Committed: http://github.com/Juniper/contrail-common/commit/e418b474b371c43bb55080f70211b9324ee09133
Submitter: Zuul (<email address hidden>)
Branch: master

commit e418b474b371c43bb55080f70211b9324ee09133
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jan 5 16:55:54 2018 +0100

CCFLAGS changes for Windows

Initial changes:
https://github.com/sagarkchitnis/windows/commits/master/tools/sandesh
Further work and cleanup:
https://github.com/codilime/contrail-sandesh/commits/windows

Change-Id: Idf7f920bc7b72352d29abafd28fdc36e56b673f0
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38731
Committed: http://github.com/Juniper/contrail-common/commit/0456f0957e2450b641c1f1260c7f437db1de22bd
Submitter: Zuul (<email address hidden>)
Branch: master

commit 0456f0957e2450b641c1f1260c7f437db1de22bd
Author: Mateusz Jablonski <email address hidden>
Date: Mon Jan 8 17:21:39 2018 +0100

Partial fixes for Agent compilation on Windows

1. Compile some files on specific platforms only
2. Remove unnecessary files, includes and constants
3. Use std::chrono on Windows
(__cplusplus value is invalid on Windows)
4. Do not use SIGCHLD on Windows
5. Add type casting because of different `{get,set}sockopt` signatures
6. Change boost::asio::error::eof
(because of name conflict with eof() function)
7. Remove incorrect implementation of GetContrailVersionInfo on Windows

Change-Id: Id523d3bae12028a6fe5873999572cfc1bc871b0a
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38785
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38771
Committed: http://github.com/Juniper/contrail-controller/commit/0a0a983bdf11070a7d489b95c1eef58239983398
Submitter: Zuul (<email address hidden>)
Branch: master

commit 0a0a983bdf11070a7d489b95c1eef58239983398
Author: Michał Cłapiński <email address hidden>
Date: Tue Jan 9 20:40:13 2018 +0100

Fixed line endings

1. Fixed line endings (Windows-style to Unix-style)
2. Removed useless file

Change-Id: I9de46f28daf8da0ac15acbbb5c9bd91e400a1ae0
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38796
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38816
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38820
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38796
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38822
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38769
Committed: http://github.com/Juniper/contrail-controller/commit/6ab3a5cb7fe08b9b3b41d7dd215b4570ffd82827
Submitter: Zuul (<email address hidden>)
Branch: master

commit 6ab3a5cb7fe08b9b3b41d7dd215b4570ffd82827
Author: Michał Cłapiński <email address hidden>
Date: Tue Jan 9 16:41:04 2018 +0100

Updated lib/SConscript for Windows

Updated lib/SConscript with calls to correct Windows-only third-party-dependencies SConscripts

Change-Id: I588fbe1b1f7301bfa9bed269496d7a13cbce8846
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38854
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38820
Committed: http://github.com/Juniper/contrail-vrouter/commit/7cfd83ad081b6418adb536ee42e93048c408e985
Submitter: Zuul (<email address hidden>)
Branch: master

commit 7cfd83ad081b6418adb536ee42e93048c408e985
Author: Michał Cłapiński <email address hidden>
Date: Thu Jan 11 14:22:05 2018 +0100

Fixed recvmsg function on Windows

Added one missing argument - bool msg_wait

Change-Id: Ib8a9b663cb465d47cf0187a5b74c6e05139f7697
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38785
Committed: http://github.com/Juniper/contrail-common/commit/a4a5400e383c3889a6e0affec713764eece1cb82
Submitter: Zuul (<email address hidden>)
Branch: master

commit a4a5400e383c3889a6e0affec713764eece1cb82
Author: Michał Cłapiński <email address hidden>
Date: Wed Jan 10 11:43:00 2018 +0100

Fixed endlines in base

Fixed line endings (Windows-style to Unix-style)

Change-Id: Ib4ad921a488703b18fd81ab7fe4559c1fe2787d2
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38816
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38822
Committed: http://github.com/Juniper/contrail-build/commit/b3adbb7b81bbaf1d059e9af9c3873c298299c45f
Submitter: Zuul (<email address hidden>)
Branch: master

commit b3adbb7b81bbaf1d059e9af9c3873c298299c45f
Author: Mateusz Jablonski <email address hidden>
Date: Thu Jan 11 17:48:28 2018 +0100

Add VS_BUILDMODE env variable

Changes required for building some libraries on Windows

Change-Id: Ie194c570dca34113b0f6a15dfd2de0d9114516b2
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38816
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38854
Committed: http://github.com/Juniper/contrail-vrouter/commit/bff616286aa4f6a30df0b58c5976a24ed48c2b05
Submitter: Zuul (<email address hidden>)
Branch: master

commit bff616286aa4f6a30df0b58c5976a24ed48c2b05
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jan 12 10:54:37 2018 +0100

Use env['VS_BUILDMODE'] instead of env['OPT'] on Windows

Change-Id: I567242de0242ac40fc4cc35802dca0f62aabfb0b
Depends-On: Ie194c570dca34113b0f6a15dfd2de0d9114516b2
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38796
Committed: http://github.com/Juniper/contrail-controller/commit/8c2480401bd730c5f4fb090f174582c758a015e8
Submitter: Zuul (<email address hidden>)
Branch: master

commit 8c2480401bd730c5f4fb090f174582c758a015e8
Author: Michał Cłapiński <email address hidden>
Date: Wed Jan 10 20:21:11 2018 +0100

Various fixes for Windows

1. INFDEFed code for huge pages and SIGHUP
2. Moved to C++ standard independent Ip?Address::bytes_type
3. Fixed bug where std::map with C array as key tried to be created
(C arrays don't meet the requirements for map's key - to be copyable
and assignable)
4. Changed DELETE to DEL (DELETE is reserved on Windows)

Change-Id: I5555d11f13e3114f51b7adbe9d2cb24449c41ea0
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38816
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38897
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38816
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38897
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38968
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38969
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38970
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38968
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38969
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38816
Committed: http://github.com/Juniper/contrail-controller/commit/3211b4dac22b45a1ed9a4a142a592b9d2b7b5e10
Submitter: Zuul (<email address hidden>)
Branch: master

commit 3211b4dac22b45a1ed9a4a142a592b9d2b7b5e10
Author: Mateusz Jablonski <email address hidden>
Date: Thu Jan 11 12:50:03 2018 +0100

Add SConscripts implementation for Windows

1. rabbitmq-c
2. SimpleAmqpClient
3. Required changes in other SConscripts
4. Use env['VS_BUILDMODE'] instead of env['OPT']

Depends-On: Ie194c570dca34113b0f6a15dfd2de0d9114516b2
Depends-On: I588fbe1b1f7301bfa9bed269496d7a13cbce8846
Change-Id: I39b2a497a802c86159494bab9bd5762cb3827620
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38970
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38897
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38969
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38968
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38969
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38995
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38996
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39000
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38969
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39000
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38996
Committed: http://github.com/Juniper/contrail-common/commit/5aeb76bee0324839a6340d607b417d4a8b1eb747
Submitter: Zuul (<email address hidden>)
Branch: master

commit 5aeb76bee0324839a6340d607b417d4a8b1eb747
Author: Mateusz Jablonski <email address hidden>
Date: Thu Jan 18 13:08:21 2018 +0100

Fix some tests compilation for Windows

Change-Id: I839b470bb1f0d156f4c79733495bd7c411c3cdfc
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38995
Committed: http://github.com/Juniper/contrail-controller/commit/8e02dbd26e0aaddc5005cb6220329a411f9e98b1
Submitter: Zuul (<email address hidden>)
Branch: master

commit 8e02dbd26e0aaddc5005cb6220329a411f9e98b1
Author: Mateusz Jablonski <email address hidden>
Date: Thu Jan 18 12:59:22 2018 +0100

Fix some tests compilation for Windows

Change-Id: If51d7a8d8aadb6b83b893cdd94013c042d6c5e52
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38970
Committed: http://github.com/Juniper/contrail-vrouter/commit/eec65458b9d5fae705757bb600f1fd85509a50d7
Submitter: Zuul (<email address hidden>)
Branch: master

commit eec65458b9d5fae705757bb600f1fd85509a50d7
Author: Michał Cłapiński <email address hidden>
Date: Wed Jan 17 17:56:17 2018 +0100

Moved files on Windows (preparation for shmem)

Change-Id: I56a58bb29ac5fa937d1b520a2fa2081ef3a7b4a6
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39000
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38969
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39000
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38968
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39112
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39113
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38897
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39113
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39112
Committed: http://github.com/Juniper/contrail-common/commit/ba50c2aac4125596fbada724660914f812dd1cd6
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit ba50c2aac4125596fbada724660914f812dd1cd6
Author: Michał Cłapiński <email address hidden>
Date: Mon Jan 22 17:06:08 2018 +0100

Revert removing staging of address.h

Basically a revert of change nr 39006

It was removed because this file had two Install() calls that
caused a minor warning. Unfortunetly the other call is in
contrail-analytics - a repository that is not downloaded on
Windows. Also contrail-common is a more basic dependency so
it should have this call and contrail-analytics should not.

Change-Id: I6b3b279c955d16250b5c3fae709fdc9e082a145e
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39113
Committed: http://github.com/Juniper/contrail-analytics/commit/93344d642260ba058bf7c1c177d39b8059f2eca7
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 93344d642260ba058bf7c1c177d39b8059f2eca7
Author: Michał Cłapiński <email address hidden>
Date: Mon Jan 22 17:13:09 2018 +0100

Remove duplicate staging of address.h

The address.h from controller/src/net has two Install() calls that cause
a minor scons warning to be issued.

It's been already removed from contrail-common but it's actually needed
there, so it should be restored there (see depends-on) and removed from here.

Change-Id: I1bb568a13a39d979720af29d1d005e482c341a6e
Depends-On: I6b3b279c955d16250b5c3fae709fdc9e082a145e
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38897
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39226
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39265
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38897
Committed: http://github.com/Juniper/contrail-controller/commit/6069d3df783584fc805e4dd84255e588c5b4ed9c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 6069d3df783584fc805e4dd84255e588c5b4ed9c
Author: Michał Cłapiński <email address hidden>
Date: Mon Jan 15 13:41:18 2018 +0100

Fix agent build on Windows

1. Simplified some SConscripts for Windows
2. GCC only __PRETTY_FUNCTION__ to standard __FUNCTION__
3. POSIX only random() to standard rand()
4. u_int8_t to standard uint8_t
5. Deprecated bzero to standard memset
6. POSIX only sysconf to platform independent boost solution
7. and more less significant fixes (mostly for C++11)

Change-Id: I5b6a9849aca56cc997ef850263e9c17162ff103b
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38968
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/38969
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38968
Committed: http://github.com/Juniper/contrail-vrouter/commit/bf89391663bcb8c44feeacef64cedadcc2a3d684
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit bf89391663bcb8c44feeacef64cedadcc2a3d684
Author: Michał Cłapiński <email address hidden>
Date: Wed Jan 17 17:40:32 2018 +0100

Level of indirection for shared memory on Windows

Platform independent:
1. Created a function for calculating bridge otable size

Windows only:
1. Written code for multiple shmem instances
2. Written code for multiple shmem devices

Change-Id: Ibd11c5afe1b41d0e1a470605ec4b37aa98418bb9
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38969
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/38969
Committed: http://github.com/Juniper/contrail-vrouter/commit/a6f6de5993f6c2990dfa7b86a7595b1e6378b754
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit a6f6de5993f6c2990dfa7b86a7595b1e6378b754
Author: Michał Cłapiński <email address hidden>
Date: Wed Jan 17 17:47:13 2018 +0100

Implemented shared memory mmap in utils on Windows

1. Moved current vr_table_map to unix_util.c
2. Implemented Windows only mmap in windows_util.c
3. Fixed bug where adding vif with util caused mcast_vrf
to be set to 0 instead of -1
4. Moved vr_netlink_port from vr_util to nl_util because it caused
linking issues

Change-Id: I218b2a8bcf6a239e27243bfef598b07da36bf0e4
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39362
Submitter: Michal Krasnoborski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39362
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39424
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39425
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39362
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39425
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39509
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39362
Committed: http://github.com/Juniper/contrail-vrouter/commit/d1ab9296e1719072307977ee025189890b9914c5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d1ab9296e1719072307977ee025189890b9914c5
Author: Michał Krasnoborski <email address hidden>
Date: Wed Jan 24 16:51:42 2018 +0100

Fix vtest on Windows

1. Add all_tests_run.ps1 script
2. Propagate error from vt_tree_traverse
3. Detect when response_process callback has not been called
4. Set netlink family when using VR_NETLINK_PROTO_TEST
5. Memzero source buffer in callbacks to avoid deallocating strings
Before this change dealocated memory was read.
6. Change nr 5 would cause mem leaks so a struct with special free
function was added
7. Add vt_packet stub for Windows (packet tests are ignored for now)
8. Renamed vrouter_get_family_id to vrouter_obtain_family_id as it
is not a simple getter and it has a lot of side effects.
#define will be removed in a follow-up change.

Change-Id: Icfe51fbd31415f7dade76d035f0c5253e2d55d23
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39424
Committed: http://github.com/Juniper/contrail-controller/commit/ce0e6080d68c82b056d0f36d58bc8dfc0040ad3c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit ce0e6080d68c82b056d0f36d58bc8dfc0040ad3c
Author: Michal Clapinski <email address hidden>
Date: Fri Feb 2 13:53:32 2018 +0100

Rename vrouter_get_family_id

Since this function is not a simple getter and has side effects it
had to be renamed.

Change-Id: I04a6d3532815343144b0a2860de55363467cd45c
Depends-On: Icfe51fbd31415f7dade76d035f0c5253e2d55d23
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39425
Committed: http://github.com/Juniper/contrail-vrouter/commit/6559b3856fda844bf7d006d310c6ade627e08368
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 6559b3856fda844bf7d006d310c6ade627e08368
Author: Michal Clapinski <email address hidden>
Date: Fri Feb 2 13:57:05 2018 +0100

Remove old define for vrouter_get_family_id

After renaming this function in contrail-controller we can safely delete
this define.

Change-Id: I61454fa828c649a98e1d5e8d1346aa4cf1cc838a
Depends-On: I04a6d3532815343144b0a2860de55363467cd45c
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39509
Committed: http://github.com/Juniper/contrail-controller/commit/2394003becda8942d50aa9d1ce3494e50ef15142
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2394003becda8942d50aa9d1ce3494e50ef15142
Author: Michal Clapinski <email address hidden>
Date: Tue Feb 6 18:42:12 2018 +0100

Don't compile KSyncSockTcp under Windows

1. Moved KSyncSockTcp class implementation to new file and enabled its
compilation only under Linux.
2. Enabled linking to tcmalloc only under Linux

Change-Id: I15447a320c632b189f6f963582bcd39a6466c760
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39226
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39632
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39677
Submitter: Michal Kostrzewa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39679
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39632
Committed: http://github.com/Juniper/contrail-controller/commit/f424b92aad7cb6d11d38a03e1fc7c752a0aa74f6
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit f424b92aad7cb6d11d38a03e1fc7c752a0aa74f6
Author: Michal Clapinski <email address hidden>
Date: Fri Feb 9 14:54:32 2018 +0100

Fixes for contrail-windows

Corrected the Linux-only types to standard C types

Change-Id: I5bbf594724d2ffea56aef4f1c040d968e71261cf
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39677
Committed: http://github.com/Juniper/contrail-controller/commit/8d46016aab153c8e0105f44a83e88365ebb418b0
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 8d46016aab153c8e0105f44a83e88365ebb418b0
Author: Michal Kostrzewa <email address hidden>
Date: Mon Feb 12 10:27:18 2018 +0100

Refactor formatting of powershell scripts.

% is an alias for ForEach-Object. It is recommended to use the verbose form.

Change-Id: I4dae2cf59c137b156305698494d20713f73c6dd2
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39679
Committed: http://github.com/Juniper/contrail-controller/commit/003f2a9ec3e8893390a6584b96f836cc1081be9a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 003f2a9ec3e8893390a6584b96f836cc1081be9a
Author: Mateusz Jablonski <email address hidden>
Date: Mon Feb 12 11:03:15 2018 +0100

Fix SConscript for Windows

Change-Id: I9ac1e7a1ea223089b7b4feaad0f1b9d238668493
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39880
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39881
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39880
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39935
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39954
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39226
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39954
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39881
Committed: http://github.com/Juniper/contrail-controller/commit/11a284cc2c1d9f8e577135b25b9f1e23a6a40898
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 11a284cc2c1d9f8e577135b25b9f1e23a6a40898
Author: Michal Clapinski <email address hidden>
Date: Mon Feb 19 19:04:15 2018 +0100

Add cmocka SConscript for Windows

Change-Id: Icef126ecda3cb9ea321d4474f7c1b06a1bdc6bcc
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39954
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39226
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39880
Committed: http://github.com/Juniper/contrail-vrouter/commit/6ce6e721063de7b6f7cf515ce3f852ccdce00d08
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 6ce6e721063de7b6f7cf515ce3f852ccdce00d08
Author: Michal Clapinski <email address hidden>
Date: Mon Feb 19 18:52:31 2018 +0100

Framework to unit test kernel-space code in userspace

Change-Id: I3b01439773a9cdb31fb473c25239c09832d41d23
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39226
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40172
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39935
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40172
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40174
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39226
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40175
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40172
Committed: http://github.com/Juniper/contrail-project-config/commit/9b93c6925258dac1b1cb654cd873109b8ee338a4
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 9b93c6925258dac1b1cb654cd873109b8ee338a4
Author: Michał Cłapiński <email address hidden>
Date: Wed Feb 28 15:38:42 2018 +0100

Install correct version of setuptools before running them

Change-Id: I64baeca845cbbb2e4c8b87c37c782896076b5165
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39935
Committed: http://github.com/Juniper/contrail-build/commit/078bc64898a74e094f80108e60d937379a3a152c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 078bc64898a74e094f80108e60d937379a3a152c
Author: Pawel Marchewka <email address hidden>
Date: Wed Feb 21 10:50:42 2018 +0100

Pip version doesn't need to be checked on Windows

Moreover we don't use targets related to python virtualenv on Windows

Change-Id: I7d42f95e4853526f55a68d243a71dc24af8f5868
Depends-On: I64baeca845cbbb2e4c8b87c37c782896076b5165
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40174
Committed: http://github.com/Juniper/contrail-vrouter/commit/c01d225abe24dd7009525701578291862f8e9b8c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c01d225abe24dd7009525701578291862f8e9b8c
Author: Michal Clapinski <email address hidden>
Date: Wed Feb 28 16:10:49 2018 +0100

Add #build/bin to path before running tests

This is needed for cmocka.dll

Change-Id: I854ea35cf1a6e41b7f8b72229fd7e6f39412b602
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39954
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39954
Committed: http://github.com/Juniper/contrail-controller/commit/8e38a1660965ab87c04b667850056b22d9cb348c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 8e38a1660965ab87c04b667850056b22d9cb348c
Author: Michal Clapinski <email address hidden>
Date: Wed Feb 21 15:29:42 2018 +0100

Remove POSIX and GCC extensions

1. bzero is not a standard C function, used memset
2. bcmp is not a standard C function, used memcmp
3. bcopy is not a standard C function, used memmove
4. Designed initializers are not a standard C++ feature, removed it
5. Structures with zero length arrays cannot be used as fields in structs
in standard C, wrote get functions instead
6. Used standard types instead of POSIX only ones
7. Generated a patch to help with future porting

Change-Id: I91f97287a8d5f25648a1a6dd87570f58e7494f38
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40331
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39226
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40380
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40482
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40485
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40482
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40486
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40485
Committed: http://github.com/Juniper/contrail-controller/commit/ba273177b53879008faf550cf524c144897fead3
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit ba273177b53879008faf550cf524c144897fead3
Author: Pawel Marchewka <email address hidden>
Date: Fri Mar 9 14:19:48 2018 +0100

Use void * instead of custom void_t

void_t may conflict with std::void_t, that is not defined as void *

Change-Id: I0873c923e891a743484ff7d01fc327b507c753c6
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40331
Committed: http://github.com/Juniper/contrail-third-party/commit/c0d13a86c36f7554c8831025117e18e9fe85853a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c0d13a86c36f7554c8831025117e18e9fe85853a
Author: Michał Cłapiński <email address hidden>
Date: Tue Mar 6 15:37:30 2018 +0100

Fixed line endings

Converted Windows-style line endings to Unix-style

Change-Id: I7ebcae812e864bf2527b463dc73cdaf6ec1a42d3
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40538
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40380
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40482
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40380
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40482
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40538
Committed: http://github.com/Juniper/contrail-vrouter/commit/7d660044fc97a44cecc6c6660d709366b1c4f983
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 7d660044fc97a44cecc6c6660d709366b1c4f983
Author: Mateusz Jablonski <email address hidden>
Date: Mon Mar 12 11:18:45 2018 +0100

Prepare vr_table_map to be used by Agent

The vr_table_map function returns error message now, so it will be
possible to use it with LOG() macro in Agent.

Change-Id: Ia15939f015f347fa370cb5ce7ca44c3edfff87f7
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40598
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40600
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40598
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40603
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40604
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40595
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40605
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40635
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40482
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40635
Committed: http://github.com/Juniper/contrail-controller/commit/6160a9048bf50d3e280b3625c8a9ed8bc194e0c5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 6160a9048bf50d3e280b3625c8a9ed8bc194e0c5
Author: Mateusz Jablonski <email address hidden>
Date: Wed Mar 14 14:51:58 2018 +0100

Fix 'agent:pkt' test compilation on Windows

1. Fix 'agent:pkt' test compilation on Windows
2. Reformat code
(lines are still shorter than 100 characters,
but looks more readable now).

Change-Id: I481445724be5cbc864930f8f72940b7e482ad206
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40595
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40651
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40595
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40651
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40598
Committed: http://github.com/Juniper/contrail-vrouter/commit/1b269e9a1334045b33506df0c2f5478079f4f0d9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 1b269e9a1334045b33506df0c2f5478079f4f0d9
Author: Mateusz Jablonski <email address hidden>
Date: Tue Mar 13 17:40:16 2018 +0100

Fixes for minor problems found while fixing bridge table on Windows

1. Add 'const' where needed
2. Remove unused defines/variables
3. Add 'void' to some C functions without arguments
4. Remove code duplication by using 'get_platform' function

Change-Id: I6b1687f32c17036247d778e673cf82c8438bae09
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40380
Committed: http://github.com/Juniper/contrail-third-party/commit/681d1230b68bf4e1609e82d6e1ef8eb29896fd35
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 681d1230b68bf4e1609e82d6e1ef8eb29896fd35
Author: Michal Clapinski <email address hidden>
Date: Wed Mar 7 12:31:04 2018 +0100

Thrift patch for Windows was missing some changes

1. Added missing ctime_r related changes to the thrift patch
2. Simplified fetch_packages.py

Change-Id: I7de2a0021bebf8df2bb131320ac0dda8c461e8df
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40605
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40651
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40735
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40604
Committed: http://github.com/Juniper/contrail-vrouter/commit/017501a9f0558ae824ca73db21ef2a863b1a2db8
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 017501a9f0558ae824ca73db21ef2a863b1a2db8
Author: Mateusz Jablonski <email address hidden>
Date: Tue Mar 13 19:18:35 2018 +0100

Create OS dependent vr_table_unlink function

Partial-Bug: #1737177

Change-Id: Ia5f0c6bb0755328bb93ea3001c52f6c13299ed1f

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40482
Committed: http://github.com/Juniper/contrail-controller/commit/14d4de9aa3d97c4f77977fd3ee8bbabb8a77e200
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 14d4de9aa3d97c4f77977fd3ee8bbabb8a77e200
Author: Mateusz Jablonski <email address hidden>
Date: Fri Mar 9 12:59:32 2018 +0100

Fix XMPP server address parsing

1. Fix parsing address without port provided.
2. Move parsing logic to separate file.
3. Add unit tests.
4. Use proper type for port variables.
5. Fix formatting (mostly tabs/spaces/newlines) -
changed automatically by code editor.
6. Fix some includes

Depends-On: I0873c923e891a743484ff7d01fc327b507c753c6
Change-Id: Ic9e4645f0fc65ef3143ba7f5f97cbe986ad1c9c6
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40746
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40748
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40750
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40751
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40750
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40750
Committed: http://github.com/Juniper/contrail-vrouter/commit/d28756d8b7af3412f57a83882c9bc97b2549e7fe
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d28756d8b7af3412f57a83882c9bc97b2549e7fe
Author: Michal Clapinski <email address hidden>
Date: Fri Mar 16 15:17:15 2018 +0100

Fix utility bugs introduced by change nr 40478

1. Remove bug where AF_BRIDGE was appended to flags
3. Remove flag NH_FLAG_COMPOSITE_L2 and set nhr_family to AF_BRIDGE
in vtest scenarios

Change-Id: I08aabf298217760b8e7fbd169abc02c76acbc41c
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40600
Committed: http://github.com/Juniper/contrail-controller/commit/1354ea6f0e19acb020628423024d2906471a146a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 1354ea6f0e19acb020628423024d2906471a146a
Author: Mateusz Jablonski <email address hidden>
Date: Tue Mar 13 18:00:23 2018 +0100

Fix bridge table implementation on Windows

1. Use constants instead of hardcoded values
2. Remove code duplication by using 'vr_table_map' function
3. Fix formatting in some includes

Depends-On: I6b1687f32c17036247d778e673cf82c8438bae09
Change-Id: I108674d5dd8c6b4564961dfa4cccc34921478f36
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40605
Committed: http://github.com/Juniper/contrail-controller/commit/d9b122757dad3a354f7c26dba7ff20f801583fb6
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d9b122757dad3a354f7c26dba7ff20f801583fb6
Author: Mateusz Jablonski <email address hidden>
Date: Tue Mar 13 19:22:09 2018 +0100

Use vr_table_unlink function

Change-Id: I33a7274ff3db04a2858c63830e0e3e20a8ade63b
Depends-On: Ia5f0c6bb0755328bb93ea3001c52f6c13299ed1f
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40603
Committed: http://github.com/Juniper/contrail-vrouter/commit/d1a4e9b7f5dbc2648d7a6351f516d55e4a650e90
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d1a4e9b7f5dbc2648d7a6351f516d55e4a650e90
Author: Mateusz Jablonski <email address hidden>
Date: Tue Mar 13 19:09:44 2018 +0100

Remove unused extern constant declaration

Depends-On: I108674d5dd8c6b4564961dfa4cccc34921478f36
Change-Id: I0078de40715927697e7d8e7225b063b0c106b5aa
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40748
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40751
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40651
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40751
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40735
Committed: http://github.com/Juniper/contrail-vrouter/commit/de42434c5d53b99680bcc0351ecb60be11bcf62f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit de42434c5d53b99680bcc0351ecb60be11bcf62f
Author: Mateusz Jablonski <email address hidden>
Date: Fri Mar 16 10:24:57 2018 +0100

Refactor 'nl_util' structure for Windows and *nix

This is first part of multiple 'nl_util' changes.
For now, the only change is removing unused fields.

The main reason of all this changes is removing all
Windows/Linux 'ifdefs/ifndefs' from
'nl_util/vr_util' headers and sources.

Change-Id: Ie6b4bbbaef5cfc3ca02040b88896d6a1f43cf6c3
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40746
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40748
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40751
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40909
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40911
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40746
Committed: http://github.com/Juniper/contrail-vrouter/commit/52069a3972632318609ee9d43b38f36897255f98
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 52069a3972632318609ee9d43b38f36897255f98
Author: Mateusz Jablonski <email address hidden>
Date: Fri Mar 16 15:07:45 2018 +0100

Refactor 'nl_util' structure for Windows and *nix

This is one of multiple 'nl_util' changes.
This change includes only better formatting
and removing unused 'return' keywords.

The main reason of all this changes is removing all
Windows/Linux 'ifdefs/ifndefs' from
'nl_util/vr_util' headers and sources.

Change-Id: Id782ee6d848015f1795c43830b1ba7dc88bc737a
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40748
Committed: http://github.com/Juniper/contrail-vrouter/commit/48c8d4d98c31d7ae30897f098b49cdb52dd6022e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 48c8d4d98c31d7ae30897f098b49cdb52dd6022e
Author: Mateusz Jablonski <email address hidden>
Date: Fri Mar 16 15:21:32 2018 +0100

Refactor 'nl_util' structure for Windows and *nix

This is one of multiple 'nl_util' changes.
This change includes moving 'vrouter_obtain_family_id'
function to OS dependent source files.

The main reason of all this changes is removing all
Windows/Linux 'ifdefs/ifndefs' from
'nl_util/vr_util' headers and sources.

Change-Id: I581a65b198cca6cd3f8ce1281c61456024279496
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40751
Committed: http://github.com/Juniper/contrail-vrouter/commit/424fa50892cc6c557f35b102991735b6135826b4
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 424fa50892cc6c557f35b102991735b6135826b4
Author: Mateusz Jablonski <email address hidden>
Date: Fri Mar 16 15:48:59 2018 +0100

Refactor 'nl_util' structure for Windows and *nix

This is one of multiple 'nl_util' changes.
This change includes:
1. Making *nix specific fields from nl_client
defined only on *nix systems.
2. Adding code for closing Windows KSync pipe.
3. Moving 'nl_free' OS specific code to separate files.
4. Moving 'nl_parse_reply' OS specific code to separate files.
5. Moving 'reset_cl_sock' OS specific code to separate files.

The main reason of all this changes is removing all
Windows/Linux 'ifdefs/ifndefs' from
'nl_util/vr_util' headers and sources.

Change-Id: I6bbda8550af0034eb8f068daac0f170dbff375fa
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40909
Committed: http://github.com/Juniper/contrail-vrouter/commit/40ad15c8a622345d4001d4e8ae923d548e7e899a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 40ad15c8a622345d4001d4e8ae923d548e7e899a
Author: Mateusz Jablonski <email address hidden>
Date: Wed Mar 21 15:11:42 2018 +0100

Refactor 'vr_get_nl_client'

Move all Windows code from 'vr_get_nl_client'
to 'nl_socket' and 'nl_connect'.

Change-Id: I323724a9ea370f18af08abbede061cf81df08a77
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40911
Committed: http://github.com/Juniper/contrail-controller/commit/0b32f6e2a262d933935c46166754b8ba2ed7f6f8
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 0b32f6e2a262d933935c46166754b8ba2ed7f6f8
Author: Mateusz Jablonski <email address hidden>
Date: Wed Mar 21 16:06:28 2018 +0100

Use 'nl_socket' and 'nl_connect' for KSync pipe on Windows

Change-Id: I05cbe2194fea2a10e96cbeacb58bd71842d6427d
Depends-On: I323724a9ea370f18af08abbede061cf81df08a77
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40651
Committed: http://github.com/Juniper/contrail-controller/commit/2b9e7550198f08271e7efdd99db089d623a10e95
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2b9e7550198f08271e7efdd99db089d623a10e95
Author: Michal Clapinski <email address hidden>
Date: Wed Mar 14 20:58:10 2018 +0100

Handle vhost as VmInterface in GetOsParams

Implemented virtual method ObtainOsSpecificParams in Interface
for setting os params depending on the child class

Change-Id: I7cc79754c39857446bf57d5f68ca0d3399a44265
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/41878
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/41892
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/41964
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/41965
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/41964
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/41965
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/41878
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/41878
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42014
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42017
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42019
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42021
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42022
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42023
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42024
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42025
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42026
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42027
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42022
Committed: http://github.com/Juniper/contrail-vrouter/commit/663137715e288e8d0a87332c810832f2dd3eb143
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 663137715e288e8d0a87332c810832f2dd3eb143
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:24:35 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I4042246eabd9f81accf973c6624f10f3f4a31a81
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42026
Committed: http://github.com/Juniper/contrail-build/commit/0460741b8eacbd319fa18b799d2d62f5fef7905f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 0460741b8eacbd319fa18b799d2d62f5fef7905f
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:19:57 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I9c71f1558154e902693c6175969a8895663ccbef
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42014
Committed: http://github.com/Juniper/contrail-controller/commit/499694a627be0a22de888dd409bb73c5eb003bff
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 499694a627be0a22de888dd409bb73c5eb003bff
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:07:03 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I765f17008d1470d6eacb69d259211847a5fbecaf
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/41892
Committed: http://github.com/Juniper/contrail-third-party/commit/22a4f3cecc25a434f561033d7f19837c38d3008b
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 22a4f3cecc25a434f561033d7f19837c38d3008b
Author: Mateusz Jablonski <email address hidden>
Date: Fri Apr 13 17:06:03 2018 +0200

Change Boost and OpenSSL paths in Thrift project on Windows

Boost and OpenSSL libraries will be moved from third-party to system directory.

Change-Id: I1556be2892aae056bd08b25280d1b380ff887dce
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42063
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42069
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/41878
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42063
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42069
Committed: http://github.com/Juniper/contrail-third-party/commit/e7bf0fca7bafd83e204dae7a6c0e51f4478faf93
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit e7bf0fca7bafd83e204dae7a6c0e51f4478faf93
Author: Mateusz Jablonski <email address hidden>
Date: Fri Apr 13 17:06:03 2018 +0200

Change Boost and OpenSSL paths in Thrift project on Windows

Boost and OpenSSL libraries will be moved from third-party to system directory.

Change-Id: I1556be2892aae056bd08b25280d1b380ff887dce
Partial-Bug: #1737177
(cherry picked from commit 22a4f3cecc25a434f561033d7f19837c38d3008b)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/41965
Committed: http://github.com/Juniper/contrail-vrouter/commit/b6f73f06db29114b3f013a60a50db31217bf0f89
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit b6f73f06db29114b3f013a60a50db31217bf0f89
Author: Pawel Marchewka <email address hidden>
Date: Mon Apr 16 17:50:45 2018 +0200

windows: fix held udp flows

Change-Id: I76e7a967bb499aff1a47196bc52ccd548ef71be7
Closes-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/41964
Committed: http://github.com/Juniper/contrail-vrouter/commit/2cc691779b3c3802fb04a1567fabd2a9b81aeb54
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2cc691779b3c3802fb04a1567fabd2a9b81aeb54
Author: Pawel Marchewka <email address hidden>
Date: Mon Apr 16 17:50:45 2018 +0200

windows: fix held udp flows

Change-Id: I76e7a967bb499aff1a47196bc52ccd548ef71be7
Closes-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42019
Committed: http://github.com/Juniper/contrail-common/commit/68898872c17d9f71b5b64c5af0e2ae2820b544c2
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 68898872c17d9f71b5b64c5af0e2ae2820b544c2
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:17:51 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: Icf690ad6cac40a5886947085e16abf5535b4f293
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42023
Committed: http://github.com/Juniper/contrail-controller/commit/7740346693d7315508373c52f15172ed870bef15
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 7740346693d7315508373c52f15172ed870bef15
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:07:03 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I765f17008d1470d6eacb69d259211847a5fbecaf
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42025
Committed: http://github.com/Juniper/contrail-common/commit/3708ee56ff69ac87b89c68a3bcc8be8d7b63005f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 3708ee56ff69ac87b89c68a3bcc8be8d7b63005f
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:17:51 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: Icf690ad6cac40a5886947085e16abf5535b4f293
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42024
Committed: http://github.com/Juniper/contrail-api-client/commit/a0f7b5acb0b38779bc5d06455a6087299007c7a0
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit a0f7b5acb0b38779bc5d06455a6087299007c7a0
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:14:43 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I02fe6dcee44e90f60dd68c4a94d8f0319a682b7b
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42027
Committed: http://github.com/Juniper/contrail-vrouter/commit/c4152505c450932778cfb050eea3ec449b944051
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit c4152505c450932778cfb050eea3ec449b944051
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:24:35 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I4042246eabd9f81accf973c6624f10f3f4a31a81
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42021
Committed: http://github.com/Juniper/contrail-build/commit/8c874075d10dbda9b9c0972139210e329a19b450
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 8c874075d10dbda9b9c0972139210e329a19b450
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:19:57 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I9c71f1558154e902693c6175969a8895663ccbef
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42063
Committed: http://github.com/Juniper/contrail-controller/commit/16006ee8ecfad443da2e74bf72f4a2a7cfb9224d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 16006ee8ecfad443da2e74bf72f4a2a7cfb9224d
Author: Pawel Marchewka <email address hidden>
Date: Fri Apr 13 12:16:48 2018 +0200

Use boost and openssl from system on windows

Use boost and openssl from system instead of third_party on windows

Change-Id: Id798344bd11b021946d13ed1576a70cba5cfeba2
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/41878
Committed: http://github.com/Juniper/contrail-controller/commit/403a95ab1c1830d415e7db82d4197259ab6cc31e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 403a95ab1c1830d415e7db82d4197259ab6cc31e
Author: Pawel Marchewka <email address hidden>
Date: Fri Apr 13 12:16:48 2018 +0200

Use boost and openssl from system on windows

Use boost and openssl from system instead of third_party on windows

Change-Id: Id798344bd11b021946d13ed1576a70cba5cfeba2
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42393
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42394
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42017
Committed: http://github.com/Juniper/contrail-api-client/commit/302dcf27334f908e154dbfbaa6fa8a6b7a96ede2
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 302dcf27334f908e154dbfbaa6fa8a6b7a96ede2
Author: Michal Clapinski <email address hidden>
Date: Tue Apr 17 16:14:43 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I02fe6dcee44e90f60dd68c4a94d8f0319a682b7b
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42502
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42511
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42512
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42513
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42511
Committed: http://github.com/Juniper/contrail-api-client/commit/8d8bc1d5d2e88195aca0e3ad2e67116956f7a971
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 8d8bc1d5d2e88195aca0e3ad2e67116956f7a971
Author: Pawel Marchewka <email address hidden>
Date: Wed Apr 25 12:23:53 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

GenerateDS works only with python2, hence change in shebang.

Change-Id: Ia04035064a75d631a8d2624f5d4787fef17fbcd2
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42502
Committed: http://github.com/Juniper/contrail-build/commit/fc945f961a40f63ab946c8c6209b74225c015ea0
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit fc945f961a40f63ab946c8c6209b74225c015ea0
Author: Pawel Marchewka <email address hidden>
Date: Wed Apr 25 10:18:00 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I92e03a285b70e9c68a554ea4a41fcd97e6f49eab
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42547
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/42581
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/42582
Submitter: Pawel Marchewka (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42513
Committed: http://github.com/Juniper/contrail-build/commit/c03ff0bd030747ade97c1f4c2f81bfebc88b02b1
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit c03ff0bd030747ade97c1f4c2f81bfebc88b02b1
Author: Pawel Marchewka <email address hidden>
Date: Wed Apr 25 10:18:00 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

Change-Id: I92e03a285b70e9c68a554ea4a41fcd97e6f49eab
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42512
Committed: http://github.com/Juniper/contrail-api-client/commit/04f6d5b7f8b3a7c8bae08525e6d31fc933418968
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 04f6d5b7f8b3a7c8bae08525e6d31fc933418968
Author: Pawel Marchewka <email address hidden>
Date: Wed Apr 25 12:23:53 2018 +0200

Add python3 support

Since cpython 2 has bugs that won't be fixed on Windows, we have to move
to python 3

GenerateDS works only with python2, hence change in shebang.

Change-Id: Ia04035064a75d631a8d2624f5d4787fef17fbcd2
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/42702
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39226
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/42582
Committed: http://github.com/Juniper/contrail-third-party/commit/fa3b8cab84ef9679f742fe24d49508274512f714
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit fa3b8cab84ef9679f742fe24d49508274512f714
Author: Pawel Marchewka <email address hidden>
Date: Fri Apr 27 13:29:11 2018 +0200

Updated windows_packages.xml

Added rabbitmq-c and SimpleAmqpClient
Fixed xml formatting

Change-Id: I1fe065d54094894a81c94d6bb65c64532cbcdecd
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/43088
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/43185
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/43315
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/43315
Submitter: Michal Kostrzewa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/43315
Committed: http://github.com/Juniper/contrail-windows-docker-driver/commit/d9a4ffd6ba49aa98fac0fc8947cc3604e2656ba5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d9a4ffd6ba49aa98fac0fc8947cc3604e2656ba5
Author: Michal Clapinski <email address hidden>
Date: Fri May 25 20:31:08 2018 +0200

Add new virtual-machine-interface to default security group

Also don't shout error on 404

Change-Id: I43b63b6c4abf07881c61bf7379ef410b5bd081db
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/42581
Committed: http://github.com/Juniper/contrail-third-party/commit/94c6a44e9dd9976e85cfd5fb01e0f383009f7d1b
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 94c6a44e9dd9976e85cfd5fb01e0f383009f7d1b
Author: Pawel Marchewka <email address hidden>
Date: Fri Apr 27 13:29:11 2018 +0200

Updated windows_packages.xml

Added rabbitmq-c and SimpleAmqpClient
Fixed xml formatting

Change-Id: I1fe065d54094894a81c94d6bb65c64532cbcdecd
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/43495
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/43497
Submitter: Michal Krasnoborski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/43522
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/43497
Submitter: Michal Krasnoborski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/43497
Committed: http://github.com/Juniper/contrail-windows-docker-driver/commit/87e9102010542972da82d9357dd7352573e9ac29
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 87e9102010542972da82d9357dd7352573e9ac29
Author: Michał Krasnoborski <email address hidden>
Date: Mon Jun 4 16:10:10 2018 +0200

More robust error handling of go-plugin-helpers.network.Handler.Serve

1. Catch and propagade errors of h.Serve
2. Reorder and split waiting on pipe
3. Move writing plugin spec to after we have waited for pipe.

Change-Id: Iade6c740b429dd807ac9de605d9173ec196bd48a
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/43666
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/43667
Submitter: Michal Clapinski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/43666
Committed: http://github.com/Juniper/contrail-build/commit/27796a1bd58276628fcf6aca1db3d6e31eba0888
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 27796a1bd58276628fcf6aca1db3d6e31eba0888
Author: Michal Clapinski <email address hidden>
Date: Fri Jun 8 19:18:06 2018 +0200

Fix missing sconscripts warnings on Windows

We don't clone those repositories on Windows, so we shouldn't use their
sconscripts.

Change-Id: Ib6114613fe3d2287eccb6d5dd4d33169b65e057f
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/43185
Committed: http://github.com/Juniper/contrail-vrouter/commit/2aaf8c42fd7ca83caa5dce9629d9ced492739889
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2aaf8c42fd7ca83caa5dce9629d9ced492739889
Author: Mateusz Jablonski <email address hidden>
Date: Mon May 21 16:23:48 2018 +0200

Remove ASSERTMSG

Remove ASSERTMSG which reises during kernel debugging
making debugging process very frustrating.

Change-Id: If2cf0f4f8856f1ef2edf7dd2a52b3a36bdab7ae9
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/43667
Committed: http://github.com/Juniper/contrail-controller/commit/2bb99a727839c574af3e614334f6bab4237b22e3
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2bb99a727839c574af3e614334f6bab4237b22e3
Author: Michal Clapinski <email address hidden>
Date: Fri Jun 8 19:52:58 2018 +0200

Simplify/correct SConscripts

Fix SConscripts warnings on Windows

Change-Id: Iffcb5a79e289541272a48da3200ddf54fc0a8254
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/44049
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44049
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44132
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44132
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44049
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44132
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44132
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/44049
Committed: http://github.com/Juniper/contrail-vrouter/commit/de1ebe16d125383cdd00aa135ab45d281463bc24
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit de1ebe16d125383cdd00aa135ab45d281463bc24
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jun 22 14:44:10 2018 +0200

Refactoring of Windows NBLs - Part 1

1. Add VR_PACKET_WRAPPER structure containing vr_packet and WIN_PACKET
2. Use NET_BUFFER_LIST indirectly through WIN_PACKET
3. Fake WIN_PACKET to fix tests compilation (unnecessary stub code
will be removed in next PRs)

Change-Id: I1ff3d749b6d94747c89e9a520e56a59daa4c7b6f
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/44164
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44132
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44164
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44132
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44244
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44244
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44253
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44244
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44244
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44313
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44244
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44164
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44244
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44164
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44164
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44313
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44164
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44244
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44164
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44313
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44164
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44458
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/44253
Committed: http://github.com/Juniper/contrail-controller/commit/390b9c39ea69e98eaaa933fa75ec13a1766828da
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 390b9c39ea69e98eaaa933fa75ec13a1766828da
Author: Michal Clapinski <email address hidden>
Date: Fri Jun 29 19:05:02 2018 +0200

Don't send ARP probes

When we leave the SPA (source IP) field empty in an ARP request, the
request begins to be an ARP probe. When container tries to assign
itself an IP address and receives an ARP probe, it thinks that somebody
else has that address already assigned and the address is marked as a
duplicate. To stop this behavior we should send ARP requests from normal
IP address. The idea to use service address was taken from
ArpEntry::SendArpRequest.

Change-Id: Iceec678ed125664711e1c13714514290b37e7c96
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/44492
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/44132
Committed: http://github.com/Juniper/contrail-vrouter/commit/0625ce33a43d6ad4e9034248a3aa2800917d76b2
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 0625ce33a43d6ad4e9034248a3aa2800917d76b2
Author: Dariusz Sosnowski <email address hidden>
Date: Tue Jun 26 14:08:40 2018 +0200

Introduce WinPacketClone with unit tests

- Divide win_packet.c into two files
- win_packet.c - for NDIS-independent logic
- win_packet_raw.c - only NDIS-dependent code
- Extend WIN_PACKET interface to allow cloning and establishing
parent/child relationships
- Implement WinPacketClone unit tests

Change-Id: I468772725236a1f7bc69f1a7cddaefe21b486790
Depends-On: I1ff3d749b6d94747c89e9a520e56a59daa4c7b6f
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/44244
Committed: http://github.com/Juniper/contrail-vrouter/commit/2d527e5716e639d31eea88875a581055b1c3dfe5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2d527e5716e639d31eea88875a581055b1c3dfe5
Author: Dariusz Sosnowski <email address hidden>
Date: Fri Jun 29 12:37:12 2018 +0200

Introduce WinPacketFreeRecursive with unit tests

This change is a part of Windows NBLs refactoring.
- Implement WinPacketFreeRecursive with all required dependencies
- Implement WinPacketFreeRecursive unit tests

Change-Id: I349da7e9f002de1a2c47c1f1ff632239d80ffbfe
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/44313
Committed: http://github.com/Juniper/contrail-vrouter/commit/cd6f3a2b0d3659c7b760bf3ba03912adf5ef7e7a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit cd6f3a2b0d3659c7b760bf3ba03912adf5ef7e7a
Author: Mateusz Jablonski <email address hidden>
Date: Tue Jul 3 13:10:42 2018 +0200

Use WinPacketFreeRecursive

Change-Id: I0ac93523b1f829eb1a4738e8448979897e0b976a
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/44164
Committed: http://github.com/Juniper/contrail-vrouter/commit/b3d243e3108bdb5ec5600211475395cd778dbd29
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit b3d243e3108bdb5ec5600211475395cd778dbd29
Author: Mateusz Jablonski <email address hidden>
Date: Wed Jun 27 15:31:53 2018 +0200

win_pclone/win_pfree refactor and unit tests

Change-Id: I120f06f4e030f33a1578edd41d5c414fe5c22b32
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/44545
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44604
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/44605
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/44653
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/44492
Committed: http://github.com/Juniper/contrail-controller/commit/02a40d9333f9d1cbc1388dbdb767a8ddf3aca01e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: R5.0

commit 02a40d9333f9d1cbc1388dbdb767a8ddf3aca01e
Author: Michal Clapinski <email address hidden>
Date: Fri Jun 29 19:05:02 2018 +0200

Don't send ARP probes

When we leave the SPA (source IP) field empty in an ARP request, the
request begins to be an ARP probe. When container tries to assign
itself an IP address and receives an ARP probe, it thinks that somebody
else has that address already assigned and the address is marked as a
duplicate. To stop this behavior we should send ARP requests from normal
IP address. The idea to use service address was taken from
ArpEntry::SendArpRequest.

Change-Id: Iceec678ed125664711e1c13714514290b37e7c96
Partial-Bug: #1737177
(cherry picked from commit 390b9c39ea69e98eaaa933fa75ec13a1766828da)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/44732
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R5.0

Review in progress for https://review.opencontrail.org/44653
Submitter: Jarek Lukow (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/44458
Committed: http://github.com/Juniper/contrail-vrouter/commit/50c8296222079ddb19129d2ff4374a1cf3bbefcd
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 50c8296222079ddb19129d2ff4374a1cf3bbefcd
Author: Mateusz Jablonski <email address hidden>
Date: Mon Jul 9 12:30:53 2018 +0200

Refactor SConscript for test/windows directory

Change-Id: I2d2c4d955abf40d7617006ce1e0b7a32ecad2222
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/44604
Committed: http://github.com/Juniper/contrail-vrouter/commit/8582f487c67476776e3b396e2a51a54fd1c16667
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 8582f487c67476776e3b396e2a51a54fd1c16667
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jul 13 16:23:02 2018 +0200

Refactor WinPacket

- Add WinPacketRaw for all OS-dependent operations
- Refactor WinPacket

Change-Id: I74d2b92e565f2e219eee0a583e8a021bdbcd333d
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/44605
Committed: http://github.com/Juniper/contrail-vrouter/commit/b6e1aeca6b4b22be1b42a5400c5a46afc27b5bd5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit b6e1aeca6b4b22be1b42a5400c5a46afc27b5bd5
Author: Mateusz Jablonski <email address hidden>
Date: Fri Jul 13 16:35:00 2018 +0200

Refactor NBL splitting

- Add WinMultiPacket
- Add WinSubPacket
- Add WinPacketList
- Add WinPacketSplitMultiPacket function

Change-Id: I011b572bfad03591d11a5d54f8e40727e3ea9f13
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/44732
Committed: http://github.com/Juniper/contrail-vrouter/commit/32b751950ae56929040d590f533f7d66444276a9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 32b751950ae56929040d590f533f7d66444276a9
Author: Mateusz Jablonski <email address hidden>
Date: Wed Jul 18 12:18:17 2018 +0200

Post-refactor changes

- Change Fake_WinPacketListRawFree implementation to use production function
- Remove dead code
- Add comment with logic explanation
- Remove unused packets definitions
- Update .gitignore

Change-Id: Ib4d4d3f063ca961a6e65a09a7a371264016b38b4
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/45261
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45263
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45441
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45522
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45558
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45441
Committed: http://github.com/Juniper/contrail-vrouter/commit/96a04515f3cf3e7a62529d1dc3860ba6dc3ad5be
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 96a04515f3cf3e7a62529d1dc3860ba6dc3ad5be
Author: Mateusz Jablonski <email address hidden>
Date: Thu Aug 9 16:42:32 2018 +0200

Fix floating IP for Windows

IPv4 packet coming from virtual interface may have
TcpChecksum or UdpChecksum flag set. In this case
TCP/UDP checksum is partially calculated so we need
to set VP_FLAG_CSUM_PARTIAL flag in vr_packet.

Change-Id: I14b060cd5f0997fc6d8c17dcf3b7d373d8089cd7
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/45558
Committed: http://github.com/Juniper/contrail-controller/commit/c3aee6f186235cce2fe85d1feb87b5d9a0e18ddb
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c3aee6f186235cce2fe85d1feb87b5d9a0e18ddb
Author: Michał Cłapiński <email address hidden>
Date: Tue Aug 14 15:09:58 2018 +0200

Unify checking OS in SConscripts

We were using two methods for checking OS, sys.platform and
platform.system(). Now we only used platform.system() as its
output is more user friendly, eg. 'Windows' instead of 'win32'

Change-Id: I59df572358da40f5cc939616ee1502d2a1e615f0
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/45263
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45522
Submitter: Dariusz Sosnowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45263
Committed: http://github.com/Juniper/contrail-controller/commit/571d0d21d116f7669899908b850e2ff6ed3ea31b
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 571d0d21d116f7669899908b850e2ff6ed3ea31b
Author: Michal Clapinski <email address hidden>
Date: Fri Aug 3 18:29:26 2018 +0200

Don't build unnecessary modules on Windows

Change-Id: I4982cfd3ceb5bcc24419cbf9889c9b8f357913d1
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/45261
Committed: http://github.com/Juniper/contrail-api-client/commit/2dba0f92ad71802f8678631f6a606646c6e8310d
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 2dba0f92ad71802f8678631f6a606646c6e8310d
Author: Michal Clapinski <email address hidden>
Date: Fri Aug 3 18:23:15 2018 +0200

Don't build unnecessary api-lib on Windows

Change-Id: Ia441d608457b171c1e7399779d55ea92e8d6fb44
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/45522
Committed: http://github.com/Juniper/contrail-vrouter/commit/cb547e1ab74ee367efb9c64d8f5fcd776b8eda79
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit cb547e1ab74ee367efb9c64d8f5fcd776b8eda79
Author: Dariusz Sosnowski <email address hidden>
Date: Mon Aug 13 11:27:29 2018 +0200

windows: Unit tests for atomic operation wrappers

Initial work:
https://github.com/codilime/contrail-vrouter/commits/windows

Change-Id: I6ad28206d224ffa354c624296792c334f27d6da5
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/45890
Submitter: Michal Krasnoborski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45890
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46026
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45890
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46026
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45890
Submitter: Jacek Izykowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45890
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46026
Committed: http://github.com/Juniper/contrail-vrouter/commit/5b4eeaee41022ff67aea9278c24ed18e5db0fab1
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 5b4eeaee41022ff67aea9278c24ed18e5db0fab1
Author: Mateusz Jablonski <email address hidden>
Date: Thu Sep 6 15:59:11 2018 +0200

Pass proper handle to NdisAllocateIoWorkItem

A handle to wrong object has been passed to
NdisAllocateIoWorkItem function causing it to always fail
which resulted in executing asynchronous callback synchronously.
In some rare cases it leads to recursively acquire
lock and finally causes a deadlock.

Change-Id: Ide96756bf1a65c54913f5dda7710c0b30233e9f2
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/45890
Submitter: Jacek Izykowski (<email address hidden>)

description: updated
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46246
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46269
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45890
Submitter: Jacek Izykowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46275
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/45890
Submitter: Jacek Izykowski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46246
Committed: http://github.com/Juniper/contrail-controller/commit/57826baf2806682010ff949f4cc05513e7b0d8b4
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 57826baf2806682010ff949f4cc05513e7b0d8b4
Author: Michal Clapinski <email address hidden>
Date: Mon Sep 17 16:59:34 2018 +0200

Poll for interface MAC address

Sometimes it takes a while for an interface to get the physical
address so it's better to poll.

Change-Id: I6171d63a217de393a41db926a8e0ce0980a7ec48
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46275
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/45890
Committed: http://github.com/Juniper/contrail-vrouter/commit/43e802164d80162eeb1e3761f6ca68bff38ec019
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 43e802164d80162eeb1e3761f6ca68bff38ec019
Author: Michał Krasnoborski <email address hidden>
Date: Thu Aug 30 17:19:59 2018 +0200

Handle LSO in windows vrouter

Change-Id: I886f6582037ce8c404c546b16d126dffd394504d
Partial-Bug: #1737177
Co-authored-by: Michal Krasnoborski <email address hidden>
Co-authored-by: Mateusz Jablonski <email address hidden>
Co-authored-by: Jacek Izykowski <email address hidden>

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46313
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46275
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46313
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46269
Committed: http://github.com/Juniper/contrail-vrouter/commit/07a81d070d2e501796b65185507a8dff74d3ce82
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 07a81d070d2e501796b65185507a8dff74d3ce82
Author: Mateusz Jablonski <email address hidden>
Date: Tue Sep 18 11:49:42 2018 +0200

Rewrite function with improper license

Change-Id: I7a90bd6892995ee041cc0cb964fe48d02f93dae1
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46275
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46313
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46275
Committed: http://github.com/Juniper/contrail-controller/commit/535ae429fa4e8c63ad61ddfca222aaf4e3719870
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 535ae429fa4e8c63ad61ddfca222aaf4e3719870
Author: Arkadiusz Kudan <email address hidden>
Date: Mon Sep 17 18:09:04 2018 +0200

Fix vDNS responding on Windows

Sometimes agent didn't respond to VMs' DNS queries
in vDNS mode. It was related to memory with the response being freed,
before Pkt0Interface::WriteHandler have been called.
With this fix, we will ensure that the memory won't be
freed until the handler of async_write function is called.

Change-Id: I07734c22be4134fc22ad1625064d7afb6a3391b7
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46313
Committed: http://github.com/Juniper/contrail-controller/commit/d362b168999011aba674d9ef0608608da6ae9f87
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d362b168999011aba674d9ef0608608da6ae9f87
Author: Arkadiusz Kudan <email address hidden>
Date: Wed Sep 19 14:59:01 2018 +0200

Implement default DNS mode on Windows

In default DNS mode VMs get list of DNS resolvers
from OS on which vRouter agent is running.
Right now, this list is read from /etc/resolv.conf file,
so it doesn't work on Windows.

To get the list of known DNS servers on Windows, we have to use
"iphlpapi" module, which is IP helper API.

This commit will logically divide implementation of building
the list of DNS resolvers in matter of OS the agent is running on.

Change-Id: Iad1b1dcd2237a4f005c8d3207b0ad3e87499326a
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46581
Submitter: Przemys?aw Marcinkiewicz (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46583
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46589
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46590
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46591
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46589
Committed: http://github.com/Juniper/contrail-windows/commit/77534f537d847e4ab347fe62b2b8f73ddb39b35b
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 77534f537d847e4ab347fe62b2b8f73ddb39b35b
Author: Michał Cłapiński <email address hidden>
Date: Fri Sep 28 18:50:12 2018 +0200

Fix endlines in the whole repository

This repository had Windows-style line endings all over.
This change converts them to Linux-style line endings.

Change-Id: I642e46abd54db3e18299c0ff3515436dabbf43af
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46590
Committed: http://github.com/Juniper/contrail-windows/commit/e47e71b4f2b82d18a545182a040dc4524c392077
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit e47e71b4f2b82d18a545182a040dc4524c392077
Author: Michał Cłapiński <email address hidden>
Date: Fri Sep 28 18:54:07 2018 +0200

Return -1 in posix stubs

We were returning 0 in stub functions without setting anything
in the passed structures. Therefore the results were dependent
on random memory. Now we return -1, so nobody should use those
structures.

Change-Id: I7c767d17a98fd8c4c1ce7042194a9c373667f044
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/46591
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/46617
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/46617
Committed: http://github.com/Juniper/contrail-vrouter/commit/5d1e5ab014dbce0e795f5ca31e87ad2fc479df98
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 5d1e5ab014dbce0e795f5ca31e87ad2fc479df98
Author: Michal Clapinski <email address hidden>
Date: Mon Oct 1 15:41:14 2018 +0200

Port mirror and vrmemstats utils for Windows

Just enabled building them.

Change-Id: I12dabf6932be3e8dae69f0c17f88c94ccf562828
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/46591
Committed: http://github.com/Juniper/contrail-controller/commit/16300d899a2d013465ee18d28594eb0f4e548ffe
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 16300d899a2d013465ee18d28594eb0f4e548ffe
Author: Michal Clapinski <email address hidden>
Date: Fri Sep 28 19:09:39 2018 +0200

Fix default paths on Windows

There are hardcoded paths to /var and /etc in agent.
This PR fixes them for Windows.

Change-Id: If9b152c83fd97765c15fd016c2ec9f26b306417e
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/47189
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47588
Submitter: Mateusz Jablonski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39226
Submitter: Micha? C?api?ski (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/47189
Submitter: Arkadiusz Kudan (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/47189
Committed: http://github.com/Juniper/contrail-controller/commit/d749fd24c130cd80ca271e2e806c89427d8d9641
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d749fd24c130cd80ca271e2e806c89427d8d9641
Author: Arkadiusz Kudan <email address hidden>
Date: Mon Oct 22 12:47:54 2018 +0200

Delete Agent's Windows service creation

This commit deletes vRouter agent's service creation
from MSI. Right now, we stick to NSSM for Windows service creation
of Contrail components, so MSI creates a "dead" service.

Change-Id: I6309dac661c4f9efb6f8b64d6353664e43ea420b
Partial-Bug: #1737177

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39226
Submitter: Micha? C?api?ski (<email address hidden>)

Changed in opencontrail:
status: New → Fix Committed
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39226
Submitter: Michal Clapinski (<email address hidden>)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.