OpenContrail

  1. Bug #1739010
  2. Comment #10

Comment 10 for bug 1739010

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40626
Committed: http://github.com/Juniper/contrail-vrouter/commit/08bff35390b34f0e2ef340435d6526c0b8234b89
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 08bff35390b34f0e2ef340435d6526c0b8234b89
Author: Andrei Bunghez <email address hidden>
Date: Tue Dec 19 13:53:30 2017 +0200

Coverity reports bad comparison for the result of pkt_pull

The result of pkt_pull is checked to be below 0 in case of error
(in nh_l2_rcv and nh_handle_mcast_control_pkt).
On the other hand, pkt_pull returns a pointer, which
makes the comparison pointless.

Change-Id: I1481a58a84f8872f05cf7bc4a045d1e41f6181d6
Closes-Bug: #1739010
(cherry picked from commit fe9d4ad6830d8c34892908a94138b4e5305b0356)