This patch updates config-download to not create a vars file under
group_vars for the server deployments. These variables end up as
hostvars in Ansible, which has caused many escaping problems since
hostvars are run through the templating engine.
In combination with I06c9b3256567cc57d599bd4d9af617c718d2314f, these
escaping problems should be eliminated.
Additionally, by not using hostvars (set_fact), we can save memory since
a hostvar is set on a host and persisted in memory. With many hosts and
large deployments (such as all hiera data), this would have eventually
been an issue.
Instead, an Ansible lookup is used in deployments.yaml to read
deployment data, which are now written to individual files by
config-download. This also improves readability instead of having one
big file of all deployment data.
Reviewed: https:/ /review. openstack. org/564056 /git.openstack. org/cgit/ openstack/ tripleo- common/ commit/ ?id=21a8c7f9059 15d2c92a9a96a0f 393f945af128bc
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit 21a8c7f905915d2 c92a9a96a0f393f 945af128bc
Author: James Slagle <email address hidden>
Date: Fri Apr 6 17:24:08 2018 -0400
Don't set deployments as hostvars
This patch updates config-download to not create a vars file under
group_vars for the server deployments. These variables end up as
hostvars in Ansible, which has caused many escaping problems since
hostvars are run through the templating engine.
In combination with I06c9b3256567cc 57d599bd4d9af61 7c718d2314f, these
escaping problems should be eliminated.
Additionally, by not using hostvars (set_fact), we can save memory since
a hostvar is set on a host and persisted in memory. With many hosts and
large deployments (such as all hiera data), this would have eventually
been an issue.
Instead, an Ansible lookup is used in deployments.yaml to read download. This also improves readability instead of having one
deployment data, which are now written to individual files by
config-
big file of all deployment data.
Change-Id: Ie09fc64cf85eb5 32f31684f1c9808 b942672ff41 b3bbbe63a1c9b9e 156c5ab5cc)
Closes-Bug: #1760990
Closes-Bug: #1763779
(cherry picked from commit 60f25d2bcd08d58