Comment 5 for bug 1289101

After spending some time reviewing the code and the proposed patches, it seems that there are three separate issues here.

1 - As described in the bug description, nova_proxy_admin_tenant_name is a tenant string as opposed to an id, and in nova_client() this name is appended to nova_compute_url incorrectly. The fix proposed by Li Ma to deprecate tenant_name in favour of tenant_id in this case makes sense.

2 - The need for bypass_url to fix the issue that Sam mentioned on a comment to patch set 10 feels like it should be addressed in a separate bug, because it could affect all code that creates connections to nova, not just admin connections that this bug addresses.

3 - Notifications will not work if nova_compute_url is not provided. The admin context is not created with a service_catalog, leading get_endpoint() to throw an EmptyCatalog exception. A nice-to-have would be to make notifications work without the need to hardcode a URL in a configuration file, or at least find a more graceful way of informing an operator that both parameters need to be set.

I propose that we keep this bug for the first issue above, and I will create two new bugs for the other two.