The backup runner unittests have been intermittently failing
because some of the backup commands being returned don't include
gzip in the pipeline.
The problem is that the tests all use the same instance of the
BackupRunner and the is_zipped instance variable is being
altered by the various tests. Each test that is expecting
compression and/or encryption needs to set these variables
explicitly. If not, depending on the timing and ordering of
the tests, the variables may not be set as the test expects.
Put defaults for the variables (true) into the setup() method.
Removed code in the tests that set is_zipped or is_encrypted
to true and will rely on the defaults in setup() for these.
Reviewed: https:/ /review. openstack. org/228250 /git.openstack. org/cgit/ openstack/ trove/commit/ ?id=0d62cac929a 43266c5ba5899a3 ab1cc13d71a5af
Committed: https:/
Submitter: Jenkins
Branch: master
commit 0d62cac929a4326 6c5ba5899a3ab1c c13d71a5af
Author: Doug Shelley <email address hidden>
Date: Sun Sep 27 13:47:19 2015 +0000
Add unspecified options to backup unittests
The backup runner unittests have been intermittently failing
because some of the backup commands being returned don't include
gzip in the pipeline.
The problem is that the tests all use the same instance of the
BackupRunner and the is_zipped instance variable is being
altered by the various tests. Each test that is expecting
compression and/or encryption needs to set these variables
explicitly. If not, depending on the timing and ordering of
the tests, the variables may not be set as the test expects.
Put defaults for the variables (true) into the setup() method.
Removed code in the tests that set is_zipped or is_encrypted
to true and will rely on the defaults in setup() for these.
Change-Id: I74431aefe88e1a ea15ca5160a6cb5 97b59d19fbd
Closes-bug: 1500199