Comment 2 for bug 1258112

Revision history for this message
Dylan McCall (dylanmccall) wrote :

This looks like a bug in apturl. It calls into Update Manager's Python modules with its own bogus 'window_main' object (which happens to provide a similar interface to Update Manager, until recently). I didn't realize this was happening when I originally refactored it: I'd been working on the assumption that Update Manager's code was all private. Sorry about that!

Frankly, though, this seems very broken on apturl's part, and from a cursory glance I don't think its sane to fix it from update-manager's end. I had submitted a few patches to apturl for an earlier issue, so this could be patched over in a similar fashion: copy the missing interface into apturl's monstrous 'UpdateManager' / 'window_main' lookalike and run away before it gains sentience.

Can someone explain why it is structured this way? I feel like we'd be better off if apturl just used PackageKit directly, or if we're going to reuse this dialog for some reason if it at least launched Update Manager over the command line instead of using Python modules from other applications that (as far as I can tell) carry no guarantees for portability.