Ubuntu
firefox package

  1. Bug #1824409
  2. Comment #35

Comment 35 for bug 1824409

Revision history for this message
In , Jhofmann-d (jhofmann-d) wrote :

Comment on attachment 8975470
Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs whitespace.

https://reviewboard.mozilla.org/r/243752/#review253754

This is pretty fiddly to get right but I feel like you did a great job, although I'm not as immersed into this code as I was half a year ago :)

Generally this looks pretty good to me. I have one small complaint: I don't think the separator looks good on Windows 7 (non-maximized) like this. I can attach a screenshot. Considering that we're both not really working on tabs full-time anymore it's probably a good idea not to defer that to a follow-up bug.

We could consider trying to entirely hide the separator on Windows 7 (would need to check how that looks with light/dark theme, too). Let me know if you want to borrow my VM for that...