Comment on attachment 572602 PATCH
Review of attachment 572602: -----------------------------------------------------------------
::: accessible/src/atk/nsApplicationAccessibleWrap.cpp @@ +912,5 @@ > + switch (dbus_message_iter_get_arg_type (&iter_variant)) { > + case DBUS_TYPE_STRUCT: > + // at-spi2-core 2.2.0-2.2.1 had a bug where it returned a struct > + dbus_message_iter_recurse (&iter_variant, &iter_struct); > + if (dbus_message_iter_get_arg_type (&iter_struct) != DBUS_TYPE_BOOLEAN) {
Did you mean == DBUS_TYPE_BOOLEAN instead?
Comment on attachment 572602
PATCH
Review of attachment 572602: ------- ------- ------- ------- ------- ------- ------- ------- --
-------
::: accessible/ src/atk/ nsApplicationAc cessibleWrap. cpp iter_get_ arg_type (&iter_variant)) { iter_recurse (&iter_variant, &iter_struct); iter_get_ arg_type (&iter_struct) != DBUS_TYPE_BOOLEAN) {
@@ +912,5 @@
> + switch (dbus_message_
> + case DBUS_TYPE_STRUCT:
> + // at-spi2-core 2.2.0-2.2.1 had a bug where it returned a struct
> + dbus_message_
> + if (dbus_message_
Did you mean == DBUS_TYPE_BOOLEAN instead?