Comment 34 for bug 857153

Revision history for this message
In , Trevor Saunders (trev-saunders) wrote :

(In reply to Karl Tomlinson (:karlt) from comment #26)
> Comment on attachment 572700 [diff] [details] [review]
> patch with nits fixed
>
> Can you provide function names and 8 lines of context with future patches,
> please? https://developer.mozilla.org/en/Installing_Mercurial#Configuration
>
> >+ DBusConnection* bus = dbus_bus_get(DBUS_BUS_SESSION, &error);
>
> dbus_bus_get() will sometimes call
> dbus_connection_set_exit_on_disconnect(TRUE), so that needs to be undone with
> another dbus_connection_set_exit_on_disconnect().

... great

> >+ reply = dbus_connection_send_with_reply_and_block(bus, message, 1000, &error);
>
> We are actively trying to shorten the start-up path to reduce start-up time.
> Blocking on DBus during creation of the first window wouldn't be helpful.
>
> Is it feasible to initialize on receipt of an async reply?

I'm not sure how bad this is in practice, but I don't forsee any huge problem with using pending calls to do this async.

> (In reply to Trevor Saunders (:tbsaunde) from comment #25)
> > It's a bit of a usability problem
> > since currently as the bug says firefox appears to be inaccessible in modern
> > linux installs.
>
> I thought GNOME 3 distros were at least providing a read-only GConf wrapper.

tbh I'm not sure, but I know we had several people confused about the problem