(In reply to Mike Gorse from comment #32) > Created attachment 577444 [diff] [details] [review] > Updated patch.
You didn't get the merge with bug 451161 right, you should probably check the use system pref first then dbus or gconf.
I'm also thinking it might be nice to put this stuff in a new file, Alex thoughts?
common nit, I tend to prefer
if (x) return;
foo();
to
if (x) return; foo();
(In reply to Mike Gorse from comment #32)
> Created attachment 577444 [diff] [details] [review]
> Updated patch.
You didn't get the merge with bug 451161 right, you should probably check the use system pref first then dbus or gconf.
I'm also thinking it might be nice to put this stuff in a new file, Alex thoughts?
common nit, I tend to prefer
if (x)
return;
foo();
to
if (x)
return;
foo();