Comment 54 for bug 1530530

Revision history for this message
In , Siro-3 (siro-3) wrote :

(In reply to Steffen Winterfeldt from comment #29)
> > SeaVGABios advertises 24bpp as the panel does support 24bpp, even though the
> > VBE format should be 32bpp. I'll send a fix to SeaBIOS.
>
> Uhm, is there a way to detect this situation? Like, add at least the color
> mask
> bits up to 32?
Yes that should be working, but all VBE clients expect the bpp to match the accumulated color bit mask.

I've sent a fix to SeaBIOS.

>
> > Is the attribute VBE_WINDOW_ATTRIBUTE_RELOCATABLE required ?
>
> Good point. It isn't.
Looking at the code is seems that relocation is required as the "window" has a maximum pagesize of 64K, but I'm not familar with those addressing modes.

In VBE2.0 there's a linear framebuffer that does not need relocations at all and it's the only mode supported by coreboot's SeaVGABios implementation.

Would it be possible to add VBE2 and linear framebuffer support to gfxboot ?