Comment 6 for bug 2039475

Hi Mauricio,

sorry for the delay; traveling to Riga has been a nightmare...

El 3/11/23 a las 0:49, Mauricio Faria de Oliveira escribió:
> Hi Sergio and Jeremy (sponsor),
>
> Thanks for the great bug description/sru template, and detailed test
> steps!
>
> Could you please help clarify 3 questions I had with the upload for
> Mantic?
>
> 1) The changes between 47.0.5 and 47.0.7 [1] include 'Migration to Gnome 45',
> which seems to break backwards compatibility [2] (but I know little Desktop);
> however, gnome 45 is shipped in Mantic already [3].
>
> So, I'm curious -- is DING in the mantic-release pocket not compatible with
> gnome in mantic-release (as DING hadn't migrated to gnome 45 yet), or these
> changes are not strictly required, and DING (and this bug fix) can work fine
> without this commit?
Current DING version in Mantic is really 47.0.6; this is, it has the
first patch, but not the second one. Gnome 45 broke backwards
compatibility in the extensions, so all and everyone must be ported to
the new model. The problem is that the migration, accidentally, broke
the mechanism used to share the margins used by extensions; that is what
is fixed in the second patch.
> 2) There are differences between the upstream changes and debdiff changes on
> this micro release update (e.g., debdiff has one more translation file) [4, 5].
>
> Can you comment on whether this is expected?
The upstream keeps adding translations as long as they are added, so it
makes sense that there are updated translations there.
> 3) Some of the translation updates are changing user interface strings, right?
> Is this OK in SRUs, which are after the User Interface Freeze? [6, 7]
Some changes fix translations that weren't accurate, and other just
translates some sentences that weren't previously translated in other
languages; but the original sentences (the ones in english) have not
changed from the current Mantic version to the proposed one.
> Sorry if these questions are basic or not too relevant; but I wanted to double
> check as Other Info gave me the impression the change set would be smaller.
>
> Thanks!
> Mauricio
>
> [1]
> $ git log --oneline 47.0.5..47.0.7
> d447154f7a1a (tag: 47.0.7) Fix integration with other extensions
> e087c635bcb8 (tag: 47.0.6) Migration to Gnome 45
> 6303910d6902 Merge branch 'master' into 'master'
> 6bd9febdb86e Update Ukrainian translation #2
>
> [2]https://gitlab.com/rastersoft/desktop-icons-
> ng/-/commit/e087c635bcb84eaf9f522695d539b2c9c04e74c9#3e0d0e116c4343aa30601ca655c7c21cdf897dc7
>
> [3]https://discourse.ubuntu.com/t/mantic-minotaur-release-
> notes/35534#gnome-footprints-16
>
> [4]
> $ git diff 47.0.5..47.0.7 | diffstat -l | sort
> app/desktopManager.js
> emulateX11WindowType.js
> extension.js
> gnomeShellOverride.js
> meson.build
> metadata.json
> po/uk.po
> prefs.js
> visibleArea.js
>
> [5]
> $ curl -sL 'http://launchpadlibrarian.net/692776738/gnome-shell-extension-desktop-icons-ng_46+really47.0.5-1_46+really47.0.7-0ubuntu1.diff.gz' | zcat | diffstat -l | sort | grep -v ^debian/
> app/meson.build
> app/prefswindow.js
> extension.js
> po/ca.po
> po/uk.po
>
> [6]https://wiki.ubuntu.com/UserInterfaceFreeze
>
> [7]
>
> #: autoAr.js:240
> -#, fuzzy
> msgid "Compressing files"
> -msgstr "Стиснути {0} файл"
> +msgstr "Стиснення файлів"
>
> #: autoAr.js:315 autoAr.js:605
> msgid "Enter a password here"
> -msgstr ""
> +msgstr "Введіть пароль тут"
>
>
> ** Changed in: gnome-shell-extension-desktop-icons-ng (Ubuntu Mantic)
> Status: In Progress => Incomplete
>