Comment 150 for bug 2034477
Revision history for this message
|
|
#150 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
> Indeed, reverting e179f6914152 makes the keyboard work. I've also attached
> the dmesg output (running with amd_iommu=off, and tried a suspend/resume, it
> worked).
Great, thanks!
So that reaffirms the above findings from Hans that the magic sequence isn't needed, it's just a way to claim that the PIC really is there even if the BIOS didn't program it.
The problem is the method that e179f6914152 used to detect the PIC doesn't work here.
I see three distinct approaches:
1. We revert e179f6914152 and store a variable to indicate whether a PIC was found and pass this information on to future kexec runs. This should fix the intent of e179f6914152
2. We revert e179f6914152 and as part of the shutdown sequence or kexec sequence disable the PIC.
3. We Go back to a quirk for detection for ZEN. All AMD Zen SoCs do have a PIC, whether it's programmed or not by BIOS appears to be a decision made by the BIOS vendor.