Comment 29 for bug 982684

Comment on attachment 76324
pkexec: Set process environment from pam_getenvlist()

Review of attachment 76324:
-----------------------------------------------------------------

::: src/programs/pkexec.c
@@ +182,5 @@
> + {
> + guint n;
> + for (n = 0; envlist[n]; n++)
> + putenv (envlist[n]);
> + free (envlist);

From my reading of the manual page (haven't looked at the source), it looks to me like you need to free() the individual elements too. I.e., do what g_strfreev() does.

Right?

(Just looked at the source of Linux-PAM-1.1.6, and that does indeed appear to be the case)