Comment 20 for bug 1444883

@Alfonso

Regarding comment #18... Yes, loosening the restriction when there's no SIM(s) or there are PIN/PUK locked SIM(s) in the phone makes sense, however this bug describes a phone with a SIM that hasn't been unlocked from the Welcome screen.

As the user didn't bother, or didn't have the phone's lock code, they accessed the emergency dialer and tried to use the French emergency codes and failed. If we allow any number to be dialed at this point, it allows anyone to use the phone without first unlocking. I don't think this is acceptable, however it probably should be reviewed with product management.

So... I *still* think someone needs to do the due diligence around libphonenumber and determine whether or not the French emergency numbers are correctly identified. The ShortNumberInfo class offers several emergency number methods. One minor pain is that the methods require a region codes ( eg. "US" = United States, "CN" = China, "FR" = France, ... ). We might need create a mapping between mobile country codes and region codes in order to use the libphonenumber for this purpose. Here's the github repo:

https://github.com/googlei18n/libphonenumber

Also, at this point, I agree with you that the additional logic should be added at a higher layer than ofono. That said, a wish list bug could be opened for adding support for network-communicated emergency numbers, but as there currently isn't a standard RIL mechanism to do so, it's probably not worthwhile. As such, I'm changing the status of the ofono task to Invalid.