Ubuntu
xkeyboard-config package

[patch] Please add support for new keyboard

Bug #458206 reported by Pali
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xkeyboard-config
Won't Fix
Medium
xkeyboard-config (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

Binary package hint: xkeyboard-config

I have PS/2 keyboard "Intelligent Keyboard K04" with multimedia keys which has no support in this package.
I add xkb_symbols in symbols/inet for this keyboard and now for me works.

I attached patch (generated from http://git.debian.org/?p=pkg-xorg/data/xkb-data.git)

Tags: natty
Revision history for this message
Pali (pali) wrote :
Revision history for this message
In , Pali (pali) wrote :

I have PS/2 keyboard "Intelligent Keyboard K04" with multimedia keys which is not in keyboard list.

I add xkb_symbols in symbols/inet for this keyboard and now for me works.

I attached patch.

Revision history for this message
In , Pali (pali) wrote :

Created attachment 31534
Patch for new keyboard

Revision history for this message
In , Sergey V. Udaltsov (svu) wrote :

A couple of notes to improve your patch:

1. Why do set vendor as "Generic"? I guess there must be some company producing these kbds?

2. Did you read the submission Rules (http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules)? In particular, the section that recommends reusing sections "*_common". It seems your code can be greatly reduced by using these sections. Also, I'd appreciate if you sort kbd mapping by keycode.

Revision history for this message
In , Pali (pali) wrote :

On this keyboard, box and CD driver for Windows isnt any company name, so I dont know (There is no logo)

I create new patch which use media_nav_acpi_common, it is now correct?

Revision history for this message
In , Pali (pali) wrote :

Created attachment 32715
New patch for this keyboard

Bryce Harrington (bryce)
Changed in xkeyboard-config (Ubuntu):
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xkeyboard-config - 1.7-2ubuntu1

---------------
xkeyboard-config (1.7-2ubuntu1) lucid; urgency=low

  * Merge from debian testing. Remaining changes:
    - Split out xkb-data-i18n to be used by console-setup.
    - debian/xkeyboard-config.pot: Add pot file for translations (updated)
    - Add 101_rus.patch: Tag USA Russian Phonetic keyboard layout with
      Russian language tag.
    - Add 102_mac_aliases.patch: Fix error activating XKB config on MacBook
      due to lack of mac w/ deadkeys layout aliases.
    - Add 103_swiss_legacy.patch: Newer swiss keyboards have swapped bar and
      brokenbar as a workaround to a Microsoft mistake in the Windows
      keyboard layout.
  * Add 104_macbook_expose_and_dashboard.patch: Add keycode definitions
    required for Apples Expose & Dashboard keys (F3/F4).
    (LP: #520519)
  * Add 105_intelligent_keyboard.patch: Add support for the Intelligent
    Keyboard K04
    (LP: #458206)
 -- Bryce Harrington <email address hidden> Thu, 11 Feb 2010 13:11:49 -0800

Changed in xkeyboard-config (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
In , Pali (pali) wrote :

Is this new patch ok now?

Revision history for this message
In , Sergey V. Udaltsov (svu) wrote :

Sorry for delay.

A couple of questions:
1. I32 is mapped usually as XF86WWW. Is it absolutely essential to change it to XF86HomePage? Semantically they are very close...
2. I6D is already XF86AudioMedia. Why do you want to add it again?

Bug Watch Updater (bug-watch-updater)
Changed in xkeyboard-config:
importance: Unknown → Medium
status: Unknown → Confirmed
Revision history for this message
Bryce Harrington (bryce) wrote :

Hi Pali,

I'm attempting to get your patch for this keyboard accepted upstream, but they have a couple questions:

1. The vendor is marked 'Generic' - who is the actual vendor for this keyboard?

2. It appears that this should now be covered by media_nav_acpi_common in symbols/inet. Would you be willing to update the patch? He would prefer just changing the rules (see rules/base.m_s.part).

Changed in xkeyboard-config (Ubuntu):
status: Fix Released → Incomplete
tags: added: natty
summary: - Please add support for new keyboard
+ [patch] Please add support for new keyboard
Revision history for this message
Bryce Harrington (bryce) wrote :

Ping Pali? We're nearing the end for natty development, would be nice to get this patch resolved.

Revision history for this message
Pali (pali) wrote :

Sorry for late responce. Currently I do not have phisical access to desktop PC with this keyboard (only with ssh, but still it is hard to test xkb).

1. I remember that on keyboard is not any logo. So I do not know vendor of this keyboard.
2. I do not know xkb properly, so I do not want to rewriting patch (without access to this PC). You have more experiences with xkb, so you may correctly rewrite this patch :)

When is deadline for resolving bugs in natty? Maybe I find time for testing xkb on this PC.

Revision history for this message
In , Pali (pali) wrote :

*** Bug 34352 has been marked as a duplicate of this bug. ***

Revision history for this message
In , Pali (pali) wrote :

1. I used informations and behaviour from Windows driver. On Windows pressing is this key change URL of browser to homepage.

2. Sorry this is my mistake.

Revision history for this message
In , Sergey V. Udaltsov (svu) wrote :

I guess the difference between those keysyms lies within the app that interprets them. Does your browser support them? Is it configurable?

Revision history for this message
In , Pali (pali) wrote :

I used KDE browser Konqueror and I configured this keysym to homepage URL.

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for setting the dupes upstream and following up with them.

Beta freeze is in effect 4/11.

Changed in xkeyboard-config:
importance: Medium → Unknown
status: Confirmed → Unknown
Bug Watch Updater (bug-watch-updater)
Changed in xkeyboard-config:
importance: Unknown → Medium
status: Unknown → Confirmed
Revision history for this message
Pali (pali) wrote :

I see, that last year I rewrited patch (but still was not OK): https://bugs.freedesktop.org/attachment.cgi?id=32715

Bryce Harrington (bryce)
Changed in xkeyboard-config (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
In , Bryce Harrington (bryce) wrote :

What's the status on this bug?

We're carrying this patch (105_intelligent_keyboard.patch) in Ubuntu Precise, but I'd love to see this finalized upstream rather than carry it as a divergence from upstream.

Revision history for this message
In , Sergey V. Udaltsov (svu) wrote :

I am really not sure I should commit that keyboard...

I32 is typically XF86WWW - there is not much difference with XF86HomePage, usually handled by the DEs
I67 is XF86Reload - similar to XF86Refresh
and it is already agreed that I6D mapping is redundant.

And, on top of that, this is not used with modern xorg and evdev driver.

Bug Watch Updater (bug-watch-updater)
Changed in xkeyboard-config:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.