Ubuntu
xkeyboard-config package

  1. Bug #458206
  2. Comment #10

Comment 10 for bug 458206

Revision history for this message
In , Sergey V. Udaltsov (svu) wrote :

A couple of notes to improve your patch:

1. Why do set vendor as "Generic"? I guess there must be some company producing these kbds?

2. Did you read the submission Rules (http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules)? In particular, the section that recommends reusing sections "*_common". It seems your code can be greatly reduced by using these sections. Also, I'd appreciate if you sort kbd mapping by keycode.