Comment 18 for bug 1921658

Revision history for this message
Robie Basak (racb) wrote :

SRU review

I don't see any explanation anywhere of what exactly is wrong in readline in Bionic or how it is being fixed. Normally I would expect to see such an explanation in both the SRU template and in the upstream patch description that is being cherry-picked. But in this case neither are present.

I don't think it's appropriate to SRU this without a full understanding of what is going on - especially when it's such a common library being patched. In particular, I don't think it's possible to assess regression risk with any confidence without a full understanding of what is being changed and why.

Please could you expand on this?