Comment 6 for bug 452226

Revision history for this message
Siergiej Riaguzow (riaguzov) wrote :

I'm not sure what to do with bugs in state "Fix committed" so I'm assigning it to Arthur.

For the width and height please see private e-mail. There is a duplication in xpad_settings_init (200,200) and xpad_settings_class_init (200,200) and a long TODO in xpad_settings_init. I must admit I don't understand any of that so maybe it is good that it wasn't merged in. Someone who knows better should fix it. Currently there is this 300,300 vs 200,200 but indeed it has nothing to do with search.

For TODOs please also see the e-mail. I will repeat part of it here:

Anyway the TODO is there for investigating what is the convention and to follow it. If the convention is to return GtkWidget* from constructor AND to store GtkWidget* in *Private - we should follow that. If it is to return GtkWidget* from constructor BUT store proper pointer types in *Private - we should follow that instead. Currently there is no consistency in this regard. I promise to investigate this code style issue.