Laptops with eDP panels do not suspend when lid closed

I determined that gsd is opting not to suspend the machine because it thinks an external display is connected. This is not the case, and the i915 driver is showing that only the eDP connector (i.e. the internal display connector) is connected. So it seems that there's some problem with the logic being used to determine whether or not a given output is the built-in panel.

Okay, it turns out the problem is in gnome_rr_output_is_laptop(), so I'm changing this over to libgnome-desktop-3-2. This function needs to check for outputs starting with eDP if it's going to work correctly for this machine.

Attaching a patch that gets this machine suspending when the lid is closed.

The attachment "03_eDP_is_laptop_panel.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

Thank you for taking the time to report this bug and helping to make Ubuntu better. The issue you are reporting is an upstream one and it would be nice if somebody having it could send the bug to the developers of the software by following the instructions at https://wiki.ubuntu.com/Bugs/Upstream/GNOME. If you have done so, please tell us the number of the upstream bug (or the link), so we can add a bugwatch that will inform us about its status. Thanks in advance.

I added the upstream bug watch. However I'm not in agreement with the reclassification of this as high. This bug means that someone could close their laptop lid and think the machine is suspended when it isn't, which can have severe consequences. It's also a regression due to the recent changes in g-s-d.

I'm also adding xserver-xorg-video-intel to the bug, as I'm beginning to think the root cause of the issue may lie here. libgnome-desktop first queries with RandR to see whether or not the output drives a laptop panel, and obviously this is failing to report the status correctly. I see that there's some code in intel_display.c that's commented out to treat eDP similarly to LVDS, due to a bug [1] that marked as being fixed. It's a guess, but maybe this is why RandR fails to recognize the eDP output as driving a laptop panel?

[1] https://bugs.freedesktop.org/show_bug.cgi?id=38012

Upon further inquiry I've found out that the ConnectorType property that gnome_rr_output_is_laptop() just isn't implemented for most of the video drivers in X, and it isn't likely to be fixed in the near future.

So for precise something along the lines of the patch I've attached is going to be required. Federico Mena-Quintero commented on the upstream bug report that the patch makes sense. Is that enough to move forward with it? This really ought to be fixed for precise, or else the code in g-s-d that using this function to leave the machine running when the lid is closed ought to be removed.

Note that the patch is now applied upstream.

http://git.gnome.org/browse/gnome-desktop/commit/?id=11997d32313cd67f24cb26e18c562fa4b75ea36f

Thanks, I've uploaded that fix, it's in the unapproved queue due to beta freeze though

This bug was fixed in the package gnome-desktop3 - 3.3.90-0ubuntu2

---------------
gnome-desktop3 (3.3.90-0ubuntu2) precise; urgency=low

  * debian/control.in:
    - drop the scrollkeeper build-depends, it's not needed
  * debian/patches/git_edp_output.patch: "Laptops with eDP panels do not
    suspend when lid closed", thanks Seth Forshee (lp: #933710)
 -- Sebastien Bacher <email address hidden> Mon, 27 Feb 2012 11:52:12 +0100

Confirming working solution.
Tested on MBA4.1

Thanks.

I have the same problem in a MacBookPro5,5 with nvidia and I have installed gnome-desktop3-data 3.3.91-ubuntu2 (not sure why I don't have gnome-desktop3 package). When I open the laptop ther's an error "could not set configuration for crtc NNN" (where N is a number).