BzrTools

shell should not depend on readline

Bug #719075 reported by Martin Packman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BzrTools
Fix Released
Undecided
Martin Packman

Bug Description

The readline module is unix only. However, the cmd module that shell is based on carefully supports configurations where readline is not available. In bug 267674 the all-in-one windows installers had pyreadline added just so shell would work, this doesn't cover alternative installation methods.

Looking at the source, it seems that readline is used to provide:
1) History
2) Autocompletion

My shell provides history anyway, and path completion as an option, readline is mostly redundant and feels alien.

Related branches

lp://qastaging/~gz/bzrtools/shell_without_readline_719075
Aaron Bentley: Needs Fixing
Diff: 39 lines (+13/-6)
1 file modified
shell.py (+13/-6)
Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 719075] [NEW] shell should not depend on readline

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-02-14 06:44 PM, Martin [gz] wrote:
> My shell provides history anyway, and path completion as an option,
> readline is mostly redundant and feels alien.

If you're using "bzr shell", then your own shell's facilities are not
relevant. Why do you mention them?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1ZxF8ACgkQ0F+nu1YWqI1AFgCeLzD3HFMUWrqbugqJdfcS+qbo
idwAn3Qg6CpcI6ey8Gup3xBJ4F7VJFyE
=3jp3
-----END PGP SIGNATURE-----

Revision history for this message
Martin Packman (gz) wrote :

> If you're using "bzr shell", then your own shell's facilities are not
> relevant. Why do you mention them?

It seemed pertinent in that history works for me without further support from readline, it's a feature of the console. This means running without readline isn't crippling, it just loses the unix-style tab completion.

Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 719075] Re: shell should not depend on readline

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-02-14 07:51 PM, Martin [gz] wrote:
>> If you're using "bzr shell", then your own shell's facilities are not
>> relevant. Why do you mention them?
>
> It seemed pertinent in that history works for me without further support
> from readline, it's a feature of the console.

No, it's not. It seems like you're talking about the per-session
history, and that functionality is provided by readline, whether or not
you do anything with the module.

The history-related code you see is for loading and saving the history
between sessions. Disabling that code would not disable the per-session
history, which might be why you think it's provided by your shell.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1Z2VoACgkQ0F+nu1YWqI0pHQCcDKjVAZfcYuvgKTfQ4iOHoW/o
brgAoIRE4SV71VwwimfZ89Vxw8iZUrwg
=gcis
-----END PGP SIGNATURE-----

Martin Packman (gz)
Changed in bzrtools:
assignee: nobody → Martin [gz] (gz)
status: New → Fix Released
status: Fix Released → Fix Committed
Aaron Bentley (abentley)
Changed in bzrtools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.