Ubuntu
gnome-shell-extension-desktop-icons-ng package

Desktop icons in Mantic doesn't honor dock margins

Bug #2039475 reported by Sergio Costas on 2023-10-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	gnome-shell-extension-desktop-icons-ng (Ubuntu)	Fix Released	Undecided	Unassigned
	Mantic	Incomplete	Undecided	Unassigned

Bug Description

[Impact]

The port to Gnome Shell 45 of Desktop Icons had a bug that prevents it from honoring the Dock size when in "IntelliHide" mode, thus allowing to put icons under it. It has been fixed in upstream by fixing in DING the implementation of the protocol that allows other extensions (like Dash-to-dock, Dash-to-panel, Hide-top-bar and more) to notify DING which zones are being used by them and thus allow to avoid putting icons there, which would be unreachable when the panel/dock/bar are visible.

[Test plan]

Go to the extensions properties of Dash-to-dock or Ubuntu-dock and ensure that the "IntelliHide" option (which hides the dock when a window is below it, and shows it again when there's only "empty desktop" below it) is ENABLED, the option "panel mode: extend up to the screen borders" is DISABLED, and the "maximum size of the dock" is BELOW 100% (90% is fine).

In an empty desktop (this is, without any window) the dock should be visible, with some free space in each side (top and bottom if the dock is vertical; left and right if it is horizontal) where the underlying desktop can be seen.

Now, open any window and maximize it; the dock should hide, thus allowing the window to fill the whole screen.

Close the window. The dock should appear again.

Try to move a desktop icon (any icon; a folder, a file, the trash, the personal folder... any is right) into the free zone of any of the sides.

If the patch works, it should NOT be possible to place the icon there; if the bug is present, then it will be possible to place the icon there.

It must be also test if it is possible to put an icon in any place of the "free" desktop surface (this is: any zone that won't be obscured by a bar, dock or panel).

[Where problems could occur]

If there are problems, they can show in several ways:

- the bugfix doesn't work, and thus it will still be possible to put icons in zones that should be forbidden

- DING might fail and no icons would be visible

- DING might wrongly interpret the data sent by other extensions, reducing too much the usable zone.

[ Other info ]
It seems easiest to take the new upstream release (47.0.5 -> 47.0.7) which includes this single code commit, plus translation updates.

See original description

Tags:

Revision history for this message

Sergio Costas (rastersoft-gmail) wrote on 2023-10-16:

patch.diff Edit (1.5 KiB, text/plain)

This patch fixes the problem.

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2023-10-16:

The attachment "patch.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags:

added: patch

Daniel van Vugt (vanvugt) on 2023-10-18

tags:	added: mantic
affects:	gnome-shell-extension-desktop-icons (Ubuntu) → gnome-shell-extension-desktop-icons-ng (Ubuntu)

Revision history for this message

Sergio Costas (rastersoft-gmail) wrote on 2023-10-18:

Just a little note: it's already fixed upstream with this same patch ;-)

Jeremy Bícha (jbicha) on 2023-10-18

Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu):
status:	New → Fix Committed

Sergio Costas (rastersoft-gmail) on 2023-10-18

description:

updated

Jeremy Bícha (jbicha) on 2023-10-18

description:

updated

Jeremy Bícha (jbicha) on 2023-10-19

Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu Mantic):
status:	Fix Committed → In Progress

Jeremy Bícha (jbicha) on 2023-10-27

Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu):
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2023-10-27:

This bug was fixed in the package gnome-shell-extension-desktop-icons-ng - 46+really47.0.7-1

---------------
gnome-shell-extension-desktop-icons-ng (46+really47.0.7-1) experimental; urgency=medium

  * New upstream release
    - Fix regression that allowed desktop icons to be placed under autohidden
      Dock (LP: #2039475)

-- Jeremy Bícha <email address hidden> Wed, 18 Oct 2023 10:04:14 -0400

Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Mauricio Faria de Oliveira (mfo) wrote on 2023-11-02:

Hi Sergio and Jeremy (sponsor),

Thanks for the great bug description/sru template, and detailed test steps!

Could you please help clarify 3 questions I had with the upload for Mantic?

1) The changes between 47.0.5 and 47.0.7 [1] include 'Migration to Gnome 45',
which seems to break backwards compatibility [2] (but I know little Desktop);
however, gnome 45 is shipped in Mantic already [3].

So, I'm curious -- is DING in the mantic-release pocket not compatible with
gnome in mantic-release (as DING hadn't migrated to gnome 45 yet), or these
changes are not strictly required, and DING (and this bug fix) can work fine
without this commit?

2) There are differences between the upstream changes and debdiff changes on
this micro release update (e.g., debdiff has one more translation file) [4, 5].

Can you comment on whether this is expected?

3) Some of the translation updates are changing user interface strings, right?
Is this OK in SRUs, which are after the User Interface Freeze? [6, 7]

Sorry if these questions are basic or not too relevant; but I wanted to double
check as Other Info gave me the impression the change set would be smaller.

Thanks!
Mauricio

[1]
$ git log --oneline 47.0.5..47.0.7
d447154f7a1a (tag: 47.0.7) Fix integration with other extensions
e087c635bcb8 (tag: 47.0.6) Migration to Gnome 45
6303910d6902 Merge branch 'master' into 'master'
6bd9febdb86e Update Ukrainian translation #2

[2] https://gitlab.com/rastersoft/desktop-icons-ng/-/commit/e087c635bcb84eaf9f522695d539b2c9c04e74c9#3e0d0e116c4343aa30601ca655c7c21cdf897dc7

[3] https://discourse.ubuntu.com/t/mantic-minotaur-release-notes/35534#gnome-footprints-16

[4]
$ git diff 47.0.5..47.0.7 | diffstat -l | sort
app/desktopManager.js
emulateX11WindowType.js
extension.js
gnomeShellOverride.js
meson.build
metadata.json
po/uk.po
prefs.js
visibleArea.js

[5]
$ curl -sL 'http://launchpadlibrarian.net/692776738/gnome-shell-extension-desktop-icons-ng_46+really47.0.5-1_46+really47.0.7-0ubuntu1.diff.gz' | zcat | diffstat -l | sort | grep -v ^debian/
app/meson.build
app/prefswindow.js
extension.js
po/ca.po
po/uk.po

[6] https://wiki.ubuntu.com/UserInterfaceFreeze

[7]

#: autoAr.js:240
-#, fuzzy
msgid "Compressing files"
-msgstr "Ð¡Ñ‚Ð¸ÑÐ½ÑƒÑ‚Ð¸ {0} Ñ„Ð°Ð¹Ð»"
+msgstr "Ð¡Ñ‚Ð¸ÑÐ½ÐµÐ½Ð½Ñ Ñ„Ð°Ð¹Ð»Ñ–Ð²"

#: autoAr.js:315 autoAr.js:605
msgid "Enter a password here"
-msgstr ""
+msgstr "Ð’Ð²ÐµÐ´Ñ–Ñ‚ÑŒ Ð¿Ð°Ñ€Ð¾Ð»ÑŒ Ñ‚ÑƒÑ‚"

Hi Sergio and Jeremy (sponsor),

Thanks for the great bug description/sru template, and detailed test steps!

Could you please help clarify 3 questions I had with the upload for Mantic?

2) There are differences between the upstream changes and debdiff changes on
this micro release update (e.g., debdiff has one more translation file) [4, 5].

Can you comment on whether this is expected?

3) Some of the translation updates are changing user interface strings, right?
Is this OK in SRUs, which are after the User Interface Freeze? [6, 7]

Sorry if these questions are basic or not too relevant; but I wanted to double
check as Other Info gave me the impression the change set would be smaller.

Thanks!
Mauricio

[2] https://gitlab.com/rastersoft/desktop-icons-ng/-/commit/e087c635bcb84eaf9f522695d539b2c9c04e74c9#3e0d0e116c4343aa30601ca655c7c21cdf897dc7

[3] https://discourse.ubuntu.com/t/mantic-minotaur-release-notes/35534#gnome-footprints-16

[4]
$ git diff 47.0.5..47.0.7 | diffstat -l | sort
app/desktopManager.js
emulateX11WindowType.js
extension.js
gnomeShellOverride.js
meson.build
metadata.json
po/uk.po
prefs.js
visibleArea.js

[6] https://wiki.ubuntu.com/UserInterfaceFreeze

[7]

#: autoAr.js:240
-#, fuzzy
 msgid "Compressing files"
-msgstr "Ð¡Ñ‚Ð¸ÑÐ½ÑƒÑ‚Ð¸ {0} Ñ„Ð°Ð¹Ð»"
+msgstr "Ð¡Ñ‚Ð¸ÑÐ½ÐµÐ½Ð½Ñ Ñ„Ð°Ð¹Ð»Ñ–Ð²"

#: autoAr.js:315 autoAr.js:605
 msgid "Enter a password here"
-msgstr ""
+msgstr "Ð’Ð²ÐµÐ´Ñ–Ñ‚ÑŒ Ð¿Ð°Ñ€Ð¾Ð»ÑŒ Ñ‚ÑƒÑ‚"

Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu Mantic):
status:	In Progress → Incomplete

Revision history for this message

Sergio Costas (rastersoft-gmail) wrote on 2023-11-04: Re: [Bug 2039475] Re: Desktop icons in Mantic doesn't honor dock margins

Download full text (3.5 KiB)

Hi Mauricio,

sorry for the delay; traveling to Riga has been a nightmare...

El 3/11/23 a las 0:49, Mauricio Faria de Oliveira escribió:
> Hi Sergio and Jeremy (sponsor),
>
> Thanks for the great bug description/sru template, and detailed test
> steps!
>
> Could you please help clarify 3 questions I had with the upload for
> Mantic?
>
> 1) The changes between 47.0.5 and 47.0.7 [1] include 'Migration to Gnome 45',
> which seems to break backwards compatibility [2] (but I know little Desktop);
> however, gnome 45 is shipped in Mantic already [3].
>
> So, I'm curious -- is DING in the mantic-release pocket not compatible with
> gnome in mantic-release (as DING hadn't migrated to gnome 45 yet), or these
> changes are not strictly required, and DING (and this bug fix) can work fine
> without this commit?
Current DING version in Mantic is really 47.0.6; this is, it has the
first patch, but not the second one. Gnome 45 broke backwards
compatibility in the extensions, so all and everyone must be ported to
the new model. The problem is that the migration, accidentally, broke
the mechanism used to share the margins used by extensions; that is what
is fixed in the second patch.
> 2) There are differences between the upstream changes and debdiff changes on
> this micro release update (e.g., debdiff has one more translation file) [4, 5].
>
> Can you comment on whether this is expected?
The upstream keeps adding translations as long as they are added, so it
makes sense that there are updated translations there.
> 3) Some of the translation updates are changing user interface strings, right?
> Is this OK in SRUs, which are after the User Interface Freeze? [6, 7]
Some changes fix translations that weren't accurate, and other just
translates some sentences that weren't previously translated in other
languages; but the original sentences (the ones in english) have not
changed from the current Mantic version to the proposed one.
> Sorry if these questions are basic or not too relevant; but I wanted to double
> check as Other Info gave me the impression the change set would be smaller.
>
> Thanks!
> Mauricio
>
> [1]
> $ git log --oneline 47.0.5..47.0.7
> d447154f7a1a (tag: 47.0.7) Fix integration with other extensions
> e087c635bcb8 (tag: 47.0.6) Migration to Gnome 45
> 6303910d6902 Merge branch 'master' into 'master'
> 6bd9febdb86e Update Ukrainian translation #2
>
> [2]https://gitlab.com/rastersoft/desktop-icons-
> ng/-/commit/e087c635bcb84eaf9f522695d539b2c9c04e74c9#3e0d0e116c4343aa30601ca655c7c21cdf897dc7
>
> [3]https://discourse.ubuntu.com/t/mantic-minotaur-release-
> notes/35534#gnome-footprints-16
>
> [4]
> $ git diff 47.0.5..47.0.7 | diffstat -l | sort
> app/desktopManager.js
> emulateX11WindowType.js
> extension.js
> gnomeShellOverride.js
> meson.build
> metadata.json
> po/uk.po
> prefs.js
> visibleArea.js
>
> [5]
> $ curl -sL 'http://launchpadlibrarian.net/692776738/gnome-shell-extension-desktop-icons-ng_46+really47.0.5-1_46+really47.0.7-0ubuntu1.diff.gz' | zcat | diffstat -l | sort | grep -v ^debian/
> app/meson.build
> app/prefswindow.js
> extension.js
> po/ca.po
> po/uk.po
>
> [6]https://wiki.ubuntu.com/UserInterfaceFreeze
>
> [7]
>
> #:...

Hi Mauricio,

sorry for the delay; traveling to Riga has been a nightmare...

El 3/11/23 a las 0:49, Mauricio Faria de Oliveira escribió:
> Hi Sergio and Jeremy (sponsor),
>
> Thanks for the great bug description/sru template, and detailed test
> steps!
>
> Could you please help clarify 3 questions I had with the upload for
> Mantic?
>
> 1) The changes between 47.0.5 and 47.0.7 [1] include 'Migration to Gnome 45',
> which seems to break backwards compatibility [2] (but I know little Desktop);
> however, gnome 45 is shipped in Mantic already [3].
>
> So, I'm curious -- is DING in the mantic-release pocket not compatible with
> gnome in mantic-release (as DING hadn't migrated to gnome 45 yet), or these
> changes are not strictly required, and DING (and this bug fix) can work fine
> without this commit?
Current DING version in Mantic is really 47.0.6; this is, it has the 
first patch, but not the second one. Gnome 45 broke backwards 
compatibility in the extensions, so all and everyone must be ported to 
the new model. The problem is that the migration, accidentally, broke 
the mechanism used to share the margins used by extensions; that is what 
is fixed in the second patch.
> 2) There are differences between the upstream changes and debdiff changes on
> this micro release update (e.g., debdiff has one more translation file) [4, 5].
>
> Can you comment on whether this is expected?
The upstream keeps adding translations as long as they are added, so it 
makes sense that there are updated translations there.
> 3) Some of the translation updates are changing user interface strings, right?
> Is this OK in SRUs, which are after the User Interface Freeze? [6, 7]
Some changes fix translations that weren't accurate, and other just 
translates some sentences that weren't previously translated in other 
languages; but the original sentences (the ones in english) have not 
changed from the current Mantic version to the proposed one.
> Sorry if these questions are basic or not too relevant; but I wanted to double
> check as Other Info gave me the impression the change set would be smaller.
>
> Thanks!
> Mauricio
>
> [1]
> $ git log --oneline 47.0.5..47.0.7
> d447154f7a1a (tag: 47.0.7) Fix integration with other extensions
> e087c635bcb8 (tag: 47.0.6) Migration to Gnome 45
> 6303910d6902 Merge branch 'master' into 'master'
> 6bd9febdb86e Update Ukrainian translation #2
>
> [2]https://gitlab.com/rastersoft/desktop-icons-
> ng/-/commit/e087c635bcb84eaf9f522695d539b2c9c04e74c9#3e0d0e116c4343aa30601ca655c7c21cdf897dc7
>
> [3]https://discourse.ubuntu.com/t/mantic-minotaur-release-
> notes/35534#gnome-footprints-16
>
> [4]
> $ git diff 47.0.5..47.0.7 | diffstat -l | sort
> app/desktopManager.js
> emulateX11WindowType.js
> extension.js
> gnomeShellOverride.js
> meson.build
> metadata.json
> po/uk.po
> prefs.js
> visibleArea.js
>
> [5]
> $ curl -sL 'http://launchpadlibrarian.net/692776738/gnome-shell-extension-desktop-icons-ng_46+really47.0.5-1_46+really47.0.7-0ubuntu1.diff.gz' | zcat | diffstat -l | sort | grep -v ^debian/
> app/meson.build
> app/prefswindow.js
> extension.js
> po/ca.po
> po/uk.po
>
> [6]https://wiki.ubuntu.com/UserInterfaceFreeze
>
> [7]
>
>   #: autoAr.js:240
> -#, fuzzy
>   msgid "Compressing files"
> -msgstr "Ð¡Ñ‚Ð¸ÑÐ½ÑƒÑ‚Ð¸ {0} Ñ„Ð°Ð¹Ð»"
> +msgstr "Ð¡Ñ‚Ð¸ÑÐ½ÐµÐ½Ð½Ñ Ñ„Ð°Ð¹Ð»Ñ–Ð²"
>
>   #: autoAr.js:315 autoAr.js:605
>   msgid "Enter a password here"
> -msgstr ""
> +msgstr "Ð’Ð²ÐµÐ´Ñ–Ñ‚ÑŒ Ð¿Ð°Ñ€Ð¾Ð»ÑŒ Ñ‚ÑƒÑ‚"
>
>
> ** Changed in: gnome-shell-extension-desktop-icons-ng (Ubuntu Mantic)
>         Status: In Progress => Incomplete
>